Restructuring UI into /ui folder#408
Closed
dennyglee wants to merge 53 commits intounitycatalog:mainfrom
dennyglee:main
Closed
Restructuring UI into /ui folder#408dennyglee wants to merge 53 commits intounitycatalog:mainfrom dennyglee:main
dennyglee wants to merge 53 commits intounitycatalog:mainfrom
dennyglee:main
Conversation
introduce antd
* feat: ✨ Add CatalogsList page + ListWrapper * extract format timestamp to util + add interaction to list rows
* feat: ✨ Add CatalogsList page + ListWrapper * extract format timestamp to util + add interaction to list rows * feat: ✨ Add details layout + catalog-details hook
* feat: ✨ Add CatalogsList page + ListWrapper * extract format timestamp to util + add interaction to list rows * add sidebar layout + catalog sidebar
* feat: ✨ Add SchemaDetails Page + getSchema hook
* feat: ✨ Add schema tabs for functions tables and volumes
* feat: ✨ Add FunctionDetails page + sidebar with details * add breadcrumbs * add icon * add code block for function def * lint
* feat: ✨ Add TableDetails page + Table Sidebar details + fix metadata labels * add volume icon to details header
* feat: ✨ Create catalog flow * prefer invalidate queries for refetching all catalogs
* Update README.md * Update README.md
* Add Code of Conduct link to CONTRIBUTING.md * removed unnecessary indentation * Update CONTRIBUTING.md with governance and communication guidelines Add a new CODE_OF_CONDUCT.md
* delete schema functionality * prettier
* Add ability to edit catalog description edit modal is made to support more fields in the future if we want to edit more than just description * lint * feedback Co-authored-by: Shawn Chen <[email protected]> --------- Co-authored-by: Shawn Chen <[email protected]>
* start of login page * env and google auth button * merge with main, remove params reference * start of okta auth * initial commit for handling auth token (#67) * start of login with keycloak * handle google sign in with token * more google auth * profile dropdown * merge with main * merge with main * convert to axios * start of readme instructions * get current user endpoint (#70) clean up some other endpoints * commenting out UI until repositories are merged * clean up current user (#74) * yarn lock file * remove keycloak for now, node version error in jwt-decode dependency * commit yarn lock * remove state as useEffect dependency, comment out currentUser call for now --------- Co-authored-by: Xiang Xu <[email protected]>
…fy UI debug and development
jamieknight-db
approved these changes
Sep 4, 2024
Collaborator
jamieknight-db
left a comment
jamieknight-db
left a comment
There was a problem hiding this comment.
LGTM thank you @dennyglee
creechy
approved these changes
Sep 4, 2024
Collaborator
creechy
left a comment
creechy
left a comment
There was a problem hiding this comment.
all contained in ui/ makes sense.
Contributor
|
Nice work @dennyglee! 😄 |
Contributor
|
Just make sure you don't squash the PR and only merge it so that the commit history is preserved. |
Contributor
Author
@robertgv are you concerned that if we do a "squash and merge" that all 53 commits will be combined into one commit in the base branch? |
Contributor
@dennyglee Correct. If we squash and merge, it will combine all the commits into a single commit on the base branch. If that's the goal, perfect. But if you want to keep track of all the commits from the UI repo on the base branch, don't do the squash. |
Contributor
Author
@robertgv Ah got it, okay, let me redo this then. |
4 tasks
dennyglee
added a commit
that referenced
this pull request
Sep 6, 2024
This pull request supersedes #408 and makes some of the same changes except it provides a clean linear git history which can be rebased on top of this repositories history. Steps I followed were basically: * Make the history of unitycatalog-ui linear by performing an interactive rebase on the first commit * Use [git-filter-repo](https://github.com/newren/git-filter-repo) to rewrite its history such that everything moved to `ui/` in that repo * Merge that history into unitycatalog.git with `--allow-unrelated-histories` * Rebase against `main` to remove the merge commit * Clean up redundant files in the new tree structure **PR Checklist** - [X] A description of the changes is added to the description of this PR. - [X] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated --------- Co-authored-by: Shawn Chen <[email protected]> Co-authored-by: Robert Martinez <[email protected]> Co-authored-by: Jamie Knight <[email protected]> Co-authored-by: Robert Garcia Ventura <[email protected]> Co-authored-by: Juan Diaz <[email protected]> Co-authored-by: Xiang Xu <[email protected]> Co-authored-by: Juan Diaz <[email protected]> Co-authored-by: Shawn Chen <[email protected]> Co-authored-by: Vikas Sharma <[email protected]> Co-authored-by: Denny Lee <[email protected]>
4 tasks
vksx
added a commit
to vksx/unitycatalog
that referenced
this pull request
Oct 7, 2024
This pull request supersedes unitycatalog#408 and makes some of the same changes except it provides a clean linear git history which can be rebased on top of this repositories history. Steps I followed were basically: * Make the history of unitycatalog-ui linear by performing an interactive rebase on the first commit * Use [git-filter-repo](https://github.com/newren/git-filter-repo) to rewrite its history such that everything moved to `ui/` in that repo * Merge that history into unitycatalog.git with `--allow-unrelated-histories` * Rebase against `main` to remove the merge commit * Clean up redundant files in the new tree structure **PR Checklist** - [X] A description of the changes is added to the description of this PR. - [X] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated --------- Co-authored-by: Shawn Chen <[email protected]> Co-authored-by: Robert Martinez <[email protected]> Co-authored-by: Jamie Knight <[email protected]> Co-authored-by: Robert Garcia Ventura <[email protected]> Co-authored-by: Juan Diaz <[email protected]> Co-authored-by: Xiang Xu <[email protected]> Co-authored-by: Juan Diaz <[email protected]> Co-authored-by: Shawn Chen <[email protected]> Co-authored-by: Vikas Sharma <[email protected]> Co-authored-by: Denny Lee <[email protected]> Signed-off-by: Vikas Sharma <[email protected]>
kevinzwang
pushed a commit
to kevinzwang/unitycatalog
that referenced
this pull request
Oct 10, 2024
This pull request supersedes unitycatalog#408 and makes some of the same changes except it provides a clean linear git history which can be rebased on top of this repositories history. Steps I followed were basically: * Make the history of unitycatalog-ui linear by performing an interactive rebase on the first commit * Use [git-filter-repo](https://github.com/newren/git-filter-repo) to rewrite its history such that everything moved to `ui/` in that repo * Merge that history into unitycatalog.git with `--allow-unrelated-histories` * Rebase against `main` to remove the merge commit * Clean up redundant files in the new tree structure **PR Checklist** - [X] A description of the changes is added to the description of this PR. - [X] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated --------- Co-authored-by: Shawn Chen <[email protected]> Co-authored-by: Robert Martinez <[email protected]> Co-authored-by: Jamie Knight <[email protected]> Co-authored-by: Robert Garcia Ventura <[email protected]> Co-authored-by: Juan Diaz <[email protected]> Co-authored-by: Xiang Xu <[email protected]> Co-authored-by: Juan Diaz <[email protected]> Co-authored-by: Shawn Chen <[email protected]> Co-authored-by: Vikas Sharma <[email protected]> Co-authored-by: Denny Lee <[email protected]> Signed-off-by: Kevin Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Per #349 with the
unitycatalog-uirepo (mainbranch) code-base as part ofunitycatalogrepo (uibranch), this next set of steps is to:Restructure the
uibranch so that all code sits in the/uifolder alaRemove the following files as the
mainalready has them and would supersede this anywaysIn addition, the
link-checker.yamlwas moved the/uifolder and placed intorootand updated so that it would only check the files in the/uifolder.Going forward, the UI and the server are in the same repo and branch thus simplifying debugging, development, and deployment.