Mark some properties in the all.yaml file as required#290
Closed
ognis1205 wants to merge 2 commits intounitycatalog:mainfrom
ognis1205:fix/mark-some-properties-as-required
Closed
Mark some properties in the all.yaml file as required#290ognis1205 wants to merge 2 commits intounitycatalog:mainfrom ognis1205:fix/mark-some-properties-as-required
ognis1205 wants to merge 2 commits intounitycatalog:mainfrom
ognis1205:fix/mark-some-properties-as-required
Conversation
vikrantpuppala
approved these changes
Aug 2, 2024
Collaborator
vikrantpuppala
left a comment
vikrantpuppala
left a comment
There was a problem hiding this comment.
thank you for adding this! @haogang to merge
Contributor
Author
|
|
haogang
reviewed
Aug 8, 2024
…eFunction and FunctionInfo
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Resolves #280.
Marked some properties in the all.yaml file as required and updated the related API documents. The updating strategy is as follows:
requiredin theFooInfoschema, by referring to the properties marked asrequiredinCreateFooschema.idto required inFooInfo.Verified that it works in the local environment and does not break backward compatibility. It is also possible to consider making all properties defined as required nullable as another implementation approach, but this was not adopted.