-
Notifications
You must be signed in to change notification settings - Fork 585
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem? Please describe.
To enable eventual production deployments, I think we may need to create an interface to configure the base url from which the UI fetches data from the UC api. This is because the UI may not necessarily be served from the same host as the UC api.
Would an environment variable to set the base url of the UC api host be a good choice?
See here where the CLIENT is only provided with the api route prefix. Therefore I believe this causes the react client to default to the same host, ie. it expects the UC api to be served from the same host.
unitycatalog/ui/src/context/client.ts
Lines 1 to 11 in 5f868a7
| import axios from 'axios'; | |
| import { UC_API_PREFIX } from '../utils/constants'; | |
| /** | |
| * The singleton client instance with `baseURL`. | |
| */ | |
| export const CLIENT = axios.create({ | |
| baseURL: `${UC_API_PREFIX}`, | |
| headers: { | |
| 'Content-type': 'application/json', | |
| }, |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request