Skip to content

Fix Boost Hub link #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wooorm merged 2 commits into from
Dec 16, 2021
Merged

Fix Boost Hub link #181

wooorm merged 2 commits into from
Dec 16, 2021

Conversation

@remcohaszing
Copy link
Member

@remcohaszing remcohaszing commented Dec 10, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

It’s a dead link.

@remcohaszing
Remove Boost Hub link
9de800f 
It’s a dead link.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2021 •
edited
Loading

Codecov Report

Merging #181 (40a258c) into main (e7a9d19) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #181   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          600       600           
=========================================
  Hits           600       600

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a9d19...40a258c. Read the comment docs.

ChristianMurphy
ChristianMurphy reviewed Dec 10, 2021
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boost is still around.
Maybe we update the url to https://boostnote.io ?

@remcohaszing remcohaszing changed the title Remove Boost Hub link Update Boost Hub link Dec 16, 2021
@wooorm wooorm changed the title Update Boost Hub link Fix Boost Hub link Dec 16, 2021
@wooorm wooorm merged commit 45b3d3f into unifiedjs:main Dec 16, 2021
@wooorm wooorm added 📚 area/docs This affects documentation 💪 phase/solved Post is done labels Dec 16, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@wooorm wooorm Awaiting requested review from wooorm

Assignees

No one assigned

Labels

📚 area/docs This affects documentation 💪 phase/solved Post is done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@remcohaszing @codecov-commenter @ChristianMurphy @wooorm