Skip to content

Replace Composition with Resolved Value sections for default functions#927

Merged
aphillips merged 1 commit intomainfrom
resolve-default-functions
Nov 11, 2024
Merged

Replace Composition with Resolved Value sections for default functions#927
aphillips merged 1 commit intomainfrom
resolve-default-functions

Conversation

@eemeli
Copy link
Copy Markdown
Collaborator

@eemeli eemeli commented Nov 7, 2024

As we've now defined resolved value as a term, and e.g. formatting refers to "resolving" placeholders, we should replace/expand the "Composition" sections of default function descriptions with "Resolved Value" sections.

This should help provide a clearer basis for the text around :number offset proposed in #926, which is currently proposing two alternative resolved value definitions for :number.

@eemeli eemeli added the functions Issue pertains to the default function set label Nov 7, 2024
@eemeli eemeli requested review from aphillips and mihnita November 7, 2024 14:29
Copy link
Copy Markdown
Member

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aphillips
Copy link
Copy Markdown
Member

aphillips commented Nov 7, 2024

The :date and :time sections make me itch a bit. I want to say more than just "implementation-defined type" but don't really want to reawaken the "sleeping bear" of an issue about whether (or not) the type "trims" the other part of the value (e.g. :date removes time units or :time removes y-m-d units)

@aphillips aphillips merged commit ad2ca52 into main Nov 11, 2024
@aphillips aphillips deleted the resolve-default-functions branch November 11, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Issue pertains to the default function set

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants