Conversation
aphillips
requested changes
Aug 6, 2024
Co-authored-by: Addison Phillips <[email protected]>
aphillips
approved these changes
Aug 6, 2024
catamorphism
approved these changes
Aug 7, 2024
Collaborator
catamorphism
left a comment
catamorphism
left a comment
There was a problem hiding this comment.
Looks consistent with what we voted on.
gibson042
approved these changes
Aug 8, 2024
Collaborator
gibson042
left a comment
gibson042
left a comment
There was a problem hiding this comment.
Looks consistent with what we voted on.
Agreed.
This was referenced Aug 9, 2024
lucacasonato
approved these changes
Aug 9, 2024
Contributor
lucacasonato
left a comment
lucacasonato
left a comment
There was a problem hiding this comment.
Looks good to me too
echeran
approved these changes
Aug 9, 2024
Collaborator
echeran
left a comment
echeran
left a comment
There was a problem hiding this comment.
LGTM.
I like the extra callout of
Whitespace at the start or end of a simple message is significant,
and a part of the text of the message.
and
Whitespace at the start or end of a complex message is not significant,
and does not affect the processing of the message.
mihnita
approved these changes
Aug 12, 2024
eemeli
added a commit
to messageformat/messageformat
that referenced
this pull request
Aug 21, 2024
XM5jDcsHTyGJtQqlCi
added a commit
to XM5jDcsHTyGJtQqlCi/messageformat
that referenced
this pull request
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #610
Closes #809
Closes #848
Closes #849
CC @lucacasonato
As agreed in the balloting under #848, complex messages should be allowed to start with whitespace.