Clarify that calling MatchSelectorKeys always returns a list#828
Merged
Clarify that calling MatchSelectorKeys always returns a list#828
Conversation
Member
|
The description of this PR and the text seem different? |
aphillips
approved these changes
Jul 15, 2024
Member
aphillips
left a comment
aphillips
left a comment
There was a problem hiding this comment.
Suggestion for the fallback handling.
|
|
||
| If calling MatchSelectorKeys encounters any error, | ||
| a _Bad Selector_ error is emitted | ||
| and an empty list is returned. |
Member
There was a problem hiding this comment.
Suggested change
| and an empty list is returned. | |
| and an empty list is returned. | |
| The fallback representation of such a _message_ is | |
| the _fallback value_ for the _message_. |
Collaborator
Author
There was a problem hiding this comment.
That correction does not match what the algorithm results in. If we get an empty list here, we end up selecting the * variant.
catamorphism
approved these changes
Jul 22, 2024
eemeli
added a commit
to messageformat/messageformat
that referenced
this pull request
Aug 21, 2024
XM5jDcsHTyGJtQqlCi
added a commit
to XM5jDcsHTyGJtQqlCi/messageformat
that referenced
this pull request
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #816 (comment), as it was not previously clear that MatchSelectorKeys never fails.