Conversation
eemeli
added
fast-track
aphillips
approved these changes
Jul 15, 2024
Member
aphillips
left a comment
aphillips
left a comment
There was a problem hiding this comment.
LGTM. Some of the number ones I glance at and wonder if we should permit?
Collaborator
Author
Right now we only allow what JSON allows. Tbh I'd rather not relax that, as it's the one spec which is probably most well known that we could be using for this. |
mihnita
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while updating the JS implementation to use the official test suite.