Update spec as if PR #645 was accepted#646
Closed
catamorphism wants to merge 1 commit intounicode-org:mainfrom
Closed
Update spec as if PR #645 was accepted#646catamorphism wants to merge 1 commit intounicode-org:mainfrom
catamorphism wants to merge 1 commit intounicode-org:mainfrom
Conversation
This change updates the formatting spec to reflect the changes proposed in unicode-org#645. It should not be merged as-is. It also uses slightly different terms than the design doc in unicode-org#645, but should serve to give a sense of what the spec would look like if the "composability" design doc was accepted.
Member
|
(chair hat off) I think this is too specific. We give implementations a lot of leeway about how to implement things internally. This is one good way of organizing it. There are elements that, on an initial read, I would nitpick, but let's discuss the high-level requirements before diving into that. I appreciate the effort, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This PR is for reference purposes when reviewing #645, to show how the spec would change if the design doc in #645 was accepted. It should not be merged as-is, and also reflects a slightly earlier version of the design doc. It should still serve to give a sense of what the spec would look like if this design doc was accepted.