Merged
Conversation
eemeli
added
syntax
aphillips
requested changes
Jan 12, 2024
Member
aphillips
left a comment
aphillips
left a comment
There was a problem hiding this comment.
Good start. Some suggestions.
Co-authored-by: Addison Phillips <[email protected]>
eemeli
commented
Jan 13, 2024
aphillips
approved these changes
Jan 13, 2024
Member
aphillips
left a comment
aphillips
left a comment
There was a problem hiding this comment.
Notwithstanding my comment, I'm going to add a 'ship it' here. I'd like to merge this with one more positive review.
Co-authored-by: Addison Phillips <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed during this week's call, this adds @attributes to expression and markup with runtime impact.
For the syntax & data model, this is mostly a rebase of #450 that leaves out any discussion of what attributes might be good for, while noting that "Attributes are reserved for use by future specification versions."
For formatting, the language is rather more forbidding:
Closes #453, as using identifier brings in the same namespacing we're using for _options.
This also closes #587, as removing
@leaves the remaining symbols sorted in code point order.