Skip to content

Add proposed/accepted status to design docs#461

Merged
aphillips merged 2 commits intounicode-org:mainfrom
eemeli:design-doc-status
Sep 2, 2023
Merged

Add proposed/accepted status to design docs#461
aphillips merged 2 commits intounicode-org:mainfrom
eemeli:design-doc-status

Conversation

@eemeli
Copy link
Copy Markdown
Collaborator

@eemeli eemeli commented Aug 28, 2023

We should track and signal the status of a design document, so that we can iterate on them across multiple PRs. To keep it simple, we probably don't need more than two statuses to start with, "proposed" and "accepted".

CC @ryzokuken, who also has a design doc PR in flight.

@eemeli eemeli added design Design document or issues related to design meta labels Aug 28, 2023
@eemeli eemeli requested review from aphillips and stasm August 28, 2023 21:02
aphillips
aphillips requested changes Aug 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But otherwise ready...

@eemeli eemeli mentioned this pull request Aug 29, 2023
Merged
@eemeli
Copy link
Copy Markdown
Collaborator Author

eemeli commented Aug 29, 2023

Requesting fast-tracking.

@stasm
Copy link
Copy Markdown
Collaborator

stasm commented Aug 29, 2023

In my mind, a design doc would only be merged into main when it's accepted. Furthermore, I think that splitting a design doc into multiple PRs may again make it more difficult to track the discussion around it. Instead, I think we should encourage long-lived PRs and multiple rounds of reviews.

@eemeli
Copy link
Copy Markdown
Collaborator Author

eemeli commented Aug 30, 2023

@stasm Could you review #458, as that's effectively the prototypical reason for this change?

It's currently at 35 comments in 13 threads of review comments, most of which are hidden as resolved. If we don't make this change, we won't be able to merge the PR until all expression attribute design questions are answered, including e.g. whether it's the proper vessel for communicating "open" vs. "closed" concepts which have not yet been mentioned at all.

@eemeli eemeli mentioned this pull request Aug 31, 2023
Merged
@eemeli eemeli added the fast-track Editorial change permitted to use fast-track merge rules label Aug 31, 2023
@eemeli eemeli requested a review from aphillips September 2, 2023 10:25
@aphillips aphillips merged commit 76aaca8 into unicode-org:main Sep 2, 2023
@eemeli eemeli deleted the design-doc-status branch September 2, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aphillips aphillips aphillips approved these changes

@stasm stasm Awaiting requested review from stasm

+1 more reviewer

@ryzokuken ryzokuken ryzokuken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

design Design document or issues related to design fast-track Editorial change permitted to use fast-track merge rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eemeli @stasm @aphillips @ryzokuken