Add +start and -end sigils for markup elements#283
Merged
eemeli merged 2 commits intounicode-org:developfrom Jun 13, 2022
Merged
Add +start and -end sigils for markup elements#283eemeli merged 2 commits intounicode-org:developfrom
eemeli merged 2 commits intounicode-org:developfrom
Conversation
Collaborator
|
I think we should not start creating PRs for issues that are not (yet) agreed on. |
Collaborator
|
I will approve it to move things forward and not have these many open PRs. It does not mean I agree with this syntax, so it should not be hold against me 1 month from now ("but you approved X") There are still at least 2 open issues arguing about how to best handle "markup elements" |
mihnita
approved these changes
Jun 10, 2022
Collaborator
Author
|
Consensus: This can be merged after a rebase. |
echeran
pushed a commit
that referenced
this pull request
Sep 20, 2022
This was referenced Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #269 and elsewhere, it would be beneficial for all placeholder content to start with some sigil or indicator. For markup, the current draft has used
{b}foo{/b}; that's changes by this PR to{+b}foo{-b}.It's also intentional that this more clearly uses a style that's different from HTML and XML, in order to help close #238.