Conversation
aphillips
reviewed
Jun 8, 2025
catamorphism
reviewed
Jun 9, 2025
sffc
reviewed
Jun 9, 2025
Member
sffc
left a comment
sffc
left a comment
There was a problem hiding this comment.
Fallback algorithm seems ok, since it has an out for an implementation that doesn't support time zone conversion
eemeli
commented
Jul 14, 2025
Collaborator
Author
|
I've edited the text a bunch following the conversations around this, hopefully incorporating all of the concerns that have been raised. |
aphillips
reviewed
Jul 21, 2025
mihnita
approved these changes
Jul 21, 2025
eemeli
added a commit
to messageformat/messageformat
that referenced
this pull request
Aug 9, 2025
XM5jDcsHTyGJtQqlCi
added a commit
to XM5jDcsHTyGJtQqlCi/messageformat
that referenced
this pull request
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is proposed as a separate change from #1077, as it was not discussed on the call.
The intent with the text updated here is to clarify what happens when the
timeZoneoption is set on a date/time function.The SHOULD/MAY language that's proposed is intended to allow for an implementation that does not support time zone conversions, which I believe matches the case in JS Temporal.
Is there prior art of
localbeing used as a time zone value as we're proposing, or are there alternatives that other date/time formatters use?