Add test tags, initially for u: options#1050
Conversation
catamorphism
left a comment
catamorphism
left a comment
There was a problem hiding this comment.
The change is fine, but why not add a new file with the u:locale tests rather than removing them? (I realize it's just two tests, but it might still be good to keep what we have.)
|
They'll still be here in the git commit history, and these tests are really rather simple. |
|
Stepping back for a moment... we need to develop a way to manage items in draft. We should have tests for new functions and options. People who implement these should be able to test them. So dumpstering these tests feels bad. Can we add a test status like "draft" so users can omit the things they didn't implement? |
|
A better solution would be one that separately identifies each of the features that are not REQUIRED, as we ought to also enable the testing and validation of features that are RECOMMENDED or OPTIONAL. |
|
Draft should be separate from MUST/SHOULD/MAY. We need both. |
eemeli
force-pushed
the
drop-u-locale-tests
branch
from
0a81c2a to
93223c2
Compare
eemeli
changed the title
|
The PR has been rebased and refactored, such that it now keeps the tests, and add For an example use case, see this JS implementation commit which skips all tests with a |
catamorphism
left a comment
catamorphism
left a comment
There was a problem hiding this comment.
Good idea with the tags!
|
|
||
| ## Test Tags | ||
|
|
||
| Some of the tests are for functionality that is not stable, |
There was a problem hiding this comment.
This is not correct. Items that are not MUST are stable, just not required.
3 participants
After #1012, the
u:localeoption has Draft status, whileu:idandu:dirare RECOMMENDED. However, the tests for all three are in the same file, and indistinguishable from eahc other.We should for now drop the rather minimal tests foru:locale, and add more comprehensive tests when the status changes.See latest comments, as the PR now keeps the tests, but adds an array of tags to them.