Skip to content

Conversation

@btangmu
Copy link
Member

@btangmu btangmu commented Jan 31, 2025

-This same PR has commits for alpha, beta, and release versions, in that order

-Built with cldr tags/release-47

-Built with cldr-staging tags/release-47

-Revised cldr-generate-zip.sh to exclude .DS_Store (hidden file)

-Built with cldr tags/release-47-alpha1

-Built with cldr-staging tags/release-47-alpha1 (downloaded as cldr-staging-release-47-alpha1.tar.gz)
@btangmu btangmu self-assigned this Jan 31, 2025
@btangmu btangmu requested a review from srl295 January 31, 2025 17:59
@btangmu
Copy link
Member Author

btangmu commented Jan 31, 2025

@srl295 how does this look? Should I do cldr-generate-zip.sh now?

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ready to generate data!

@btangmu
Copy link
Member Author

btangmu commented Feb 4, 2025

The 2nd commit is for alpha2 and has the same changes as #82 but applied on top of alpha1.

See also comments in #82

@btangmu btangmu requested a review from srl295 February 4, 2025 14:31
### Updating the Repository

1. Run `git checkout -b ...` to create a new branch.
1. Run `git checkout -b ...` to create a new branch. Typical practice is to create a new branch for a major version, such as `v44`, and only merge it back to `main` upon release.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes to UPDATING.md are very helpful! In the context of this PR, the history is confusing. Changes to UPDATING.md are actually from a different PR, already merged, #71

@btangmu btangmu changed the title CLDR-18245 Generate cldr-json 47.0.0-ALPHA1 CLDR-18245 Generate cldr-json 47.0.0-ALPHA1 and ALPHA2 Feb 4, 2025
"full": "HHmmsszzzz",
"long": "HHmmssz",
"medium": "HHmmss",
"short": "HHmm"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised at how many changes there are from alpha1 to alpha2. These changes to en-GS appear to be from unicode-org/cldr#4320 last week.

@btangmu
Copy link
Member Author

btangmu commented Feb 4, 2025

@srl295 I'll wait for your go-ahead to do cldr-generate-zip.sh and tag a release for alpha2

@srl295
Copy link
Member

srl295 commented Feb 4, 2025

@srl295 I'll wait for your go-ahead to do cldr-generate-zip.sh and tag a release for alpha2

Looks good - the zip is needed so icu4x can test before going to npm

@btangmu
Copy link
Member Author

btangmu commented Feb 4, 2025

Looks good - the zip is needed so icu4x can test before going to npm

Here it is: https://github.com/unicode-org/cldr-json/releases/tag/47.0.0-ALPHA2

About npm: when do we publish on npm? alpha1, alpha2, ...? We haven't published alpha1 on npm

-Built with cldr tags/release-47-beta1

-Built with cldr-staging tags/release-47-beta1 (downloaded as cldr-staging-release-47-beta1.tar.gz)
@btangmu btangmu changed the title CLDR-18245 Generate cldr-json 47.0.0-ALPHA1 and ALPHA2 CLDR-18245 Generate cldr-json 47.0.0-ALPHA/BETA Feb 25, 2025
@btangmu btangmu changed the title CLDR-18245 Generate cldr-json 47.0.0-ALPHA/BETA CLDR-18245 Generate cldr-json 47.0.0-ALPHA/BETA/release Mar 13, 2025
-Built with cldr tags/release-47

-Built with cldr-staging tags/release-47 (downloaded as cldr-staging-release-47.tar.gz)
@btangmu
Copy link
Member Author

btangmu commented Mar 13, 2025

@srl295 the last (7th) commit is for the release data. There are no changes from beta2 except:

  • in some version numbers, "BETA2" disappears as it should
  • the slash in "/.DS_Store", which is good (though it practically makes no difference)

Should we expect any data changes from beta2?

@btangmu btangmu marked this pull request as ready for review March 13, 2025 15:29
@srl295 srl295 merged commit effc2b8 into unicode-org:main Mar 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants