CLDR-18956 cldr-json: RBNF new format #5060
Conversation
- add _rbnfRulesFile key under each rule with the name of the text file to load with the rules.
|
✨ This commit deployed to https://2facb0d0.cldr.pages.dev Changed Pages in the last commit: |
- DATA: unicode-org/cldr-staging: d763411f6 release-48-alpha3 - TOOL: unicode-org/cldr: 1cf4f283f1 release-48-alpha3-8-g1cf4f283f1 ( unicode-org/cldr#5060 ) - SCRIPT: unicode-org/cldr-json: d2f155b 48.0.0-ALPHA2D0
srl295
requested review from
btangmu,
echeran,
macchiati,
pedberg-icu,
robertbastian and
sffc
|
Question: would it be easier for clients to have the files in a differently named folder, so that all the files in a folder have the same format? |
the .txt files are referenced by the .json files, clients don't need to (and should not) "process" the .txt files independently.
I’m not sure the manifest file is needed— clients should use the available locales list from the Also, the transforms are in a similar format, see https://github.com/unicode-org/cldr-json/tree/v48/cldr-json/cldr-transforms/transforms |
|
✨ This commit deployed to https://5316f373.cldr.pages.dev Changed Pages in the last commit: |
|
✨ This commit deployed to https://65e81477.cldr.pages.dev Changed Pages in the last commit: |
|
Hm - some of the RBNF rules are identical, so we could hash the output names not as friendly to humans inspecting it, though. (not for this PR) |
sffc
left a comment
sffc
left a comment
There was a problem hiding this comment.
Seems about right; didn't do a deep review of the java code
CLDR-18956
Review Note
output is planned to appear in the forthcoming 48.0.0-ALPHA3 cldr-json release. You can see the new format at:
ALLOW_MANY_COMMITS=true