Skip to content

CLDR-18953 Add Sunu-Deva and Deva-Sunu transforms#4214

Open
NeilSureshPatel wants to merge 3 commits intounicode-org:ddl/v48from
NeilSureshPatel:CLDR-17885-Sunuwar-Transforms
Open

CLDR-18953 Add Sunu-Deva and Deva-Sunu transforms#4214
NeilSureshPatel wants to merge 3 commits intounicode-org:ddl/v48from
NeilSureshPatel:CLDR-17885-Sunuwar-Transforms

Conversation

@NeilSureshPatel
Copy link
Copy Markdown

@NeilSureshPatel NeilSureshPatel commented Nov 26, 2024 •
edited by atlassian bot
Loading

CLDR-17885

Initial commit of Sunuwar to Devanagari and Devanagari to Sunuwar transforms using the InterIndic intermediate step. Transforms are based on the SWS standard.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@srl295 srl295 self-requested a review December 19, 2024 18:11
srl295
srl295 approved these changes Dec 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great so far and note that it is draft=contributed.

Are you able to add test data? See https://github.com/unicode-org/cldr/tree/main/common/testData/transforms (note the _readme.txt there)

@NeilSureshPatel
Copy link
Copy Markdown
Author

NeilSureshPatel commented Dec 30, 2024

I think this is great so far and note that it is draft=contributed.

Are you able to add test data? See https://github.com/unicode-org/cldr/tree/main/common/testData/transforms (note the _readme.txt there)

I can pull together some test data as I get time to assemble it.

@srl295 srl295 changed the base branch from main to ddl/v48 January 18, 2025 16:50
@srl295 srl295 mentioned this pull request Jan 21, 2025
Closed
1 task
@srl295
Copy link
Copy Markdown
Member

srl295 commented Jan 21, 2025

@NeilSureshPatel
CLDR-17885 Add Sunu-Deva and Deva-Sunu transforms
e3ee82c 
CLDR-17885
Initial commit of Sunuwar to Devanagari and Devanagari to Sunuwar transforms using the InterIndic intermediate step. Transforms are based on the SWS standard. Included initial deva-t-sunu TestData

Create deva-t-sunu.txt

Initial test data set for quick validation of transforms
@NeilSureshPatel NeilSureshPatel force-pushed the CLDR-17885-Sunuwar-Transforms branch from 89af1ec to e3ee82c Compare January 22, 2025 00:11
@jira-pull-request-webhook
Copy link
Copy Markdown

jira-pull-request-webhook bot commented Jan 22, 2025

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@NeilSureshPatel
Copy link
Copy Markdown
Author

NeilSureshPatel commented Jan 22, 2025

I think I got it squashed properly, but let me know if need to do something else

@srl295
Copy link
Copy Markdown
Member

srl295 commented Jan 22, 2025

looks good

srl295 and others added 2 commits January 22, 2025 10:59
@srl295 srl295 mentioned this pull request Feb 12, 2025
Open
1 task
@srl295 srl295 mentioned this pull request Apr 30, 2025
Merged
1 task
@srl295 srl295 changed the title CLDR-17885 Add Sunu-Deva and Deva-Sunu transforms CLDR-18953 Add Sunu-Deva and Deva-Sunu transforms Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295 srl295 srl295 approved these changes

Assignees

@NeilSureshPatel NeilSureshPatel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NeilSureshPatel @CLAassistant @srl295