Repository navigation
fix(cli): render skipped steps as skipped, not complete - #876
Merged
Merged
Conversation
The CLI handled step-complete and step-skip in the same branch and filled the bar to its total for both, so a stage that never ran after an upstream failure showed a full green bar reading 100/100. The progress schema already distinguishes the two events and the studio UI maps step-skip to its own "skipped" state; only the CLI threw the information away. step-skip now leaves the bar empty and replaces the value/total column with "skipped". Per-step formats become format functions so the bar can read that flag from the payload. Fixes unicef#811 Co-Authored-By: Claude Opus 5 <[email protected]>
Collaborator
|
Hey! It looks like this PR is targeting Could you update the base branch to |
Contributor
Author
|
Done, base is now develop. The branch was already on top of develop (43814f2), so the diff is just the one change in packages/pipeline/src/cli.ts. Sorry for the noise. |
Eliezir
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The CLI handled
step-completeandstep-skipin the same branch and filled the bar to its total for both, so a stage skipped after an upstream failure showed a full bar reading100/100. The event schema already tells the two apart and the studio UI mapsstep-skipto its ownskippedstate; only the CLI threw that away.step-skipnow leaves the bar empty and replaces thevalue/totalcolumn withskipped. The per-step format becomes a format function so it can read that flag from the bar payload; nothing changes forstep-completeorstep-progress.Emitters are untouched, as the issue asks. The "Failed stages" footer question raised there is left open; this only fixes the misleading bar.
Fixes #811
Testing
pnpm typecheckclean.vitest run packages/pipeline: 67 files, 1257 tests, all passing.cli.tshas no tests of its own andcreateCliProgressis not exported, so no new test; the render above is from driving the same format function throughcli-progress3.12 with a captured stream.Written with help from Claude Code; I reviewed and ran everything myself.
🤖 Generated with Claude Code