Skip to content

[UNDERTOW-2706][UNDERTOW-2333] Undertow read/write timeout should not apply to WebSockets or SSE#1534

Merged
fl4via merged 2 commits into
undertow-io:mainfrom
baranowb:UNDERTOW-2333
Oct 16, 2024
Merged

[UNDERTOW-2706][UNDERTOW-2333] Undertow read/write timeout should not apply to WebSockets or SSE#1534
fl4via merged 2 commits into
undertow-io:mainfrom
baranowb:UNDERTOW-2333

Conversation

@baranowb

@baranowb baranowb commented Nov 7, 2023 •
edited by fl4via
Loading

Copy link
Copy Markdown
Contributor

@baranowb baranowb requested a review from fl4via April 3, 2024 08:27
@baranowb baranowb added enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review and removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor labels Apr 3, 2024
baranowb
baranowb commented Jul 1, 2024
View reviewed changes
Comment thread core/src/main/java/io/undertow/server/handlers/cache/ResponseCachingStreamSinkConduit.java
return Conduits.writeFinalBasic(this, src);
}
}
} No newline at end of file

@baranowb baranowb Jul 1, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this pops up, Ive set this file to be literal copy of one contained in previous commit yet this change somehow persists.

@ropalka ropalka self-requested a review August 7, 2024 12:21
@baranowb baranowb requested a review from jasondlee September 4, 2024 08:32
@fl4via fl4via added the new feature / API change New feature to be introduced or a change to the API (non suitable to minor releases) label Oct 16, 2024
This was referenced Oct 16, 2024
Merged
Merged
@fl4via fl4via removed the waiting peer review PRs that edit core classes might require an extra review label Oct 16, 2024
@fl4via fl4via merged commit c5281bf into undertow-io:main Oct 16, 2024
@fl4via fl4via changed the title [UNDERTOW-2333] Undertow read/write timeout should not apply to WebSockets or SSE [UNDERTOW-2706][UNDERTOW-2333] Undertow read/write timeout should not apply to WebSockets or SSE Feb 17, 2026
@fl4via fl4via added the next release This PR will be merged before next release or has already been merged (for payload double check) label Feb 17, 2026
@fl4via fl4via mentioned this pull request Feb 17, 2026
Merged
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ropalka ropalka ropalka approved these changes

@fl4via fl4via fl4via approved these changes

@jasondlee jasondlee Awaiting requested review from jasondlee

Assignees

No one assigned

Labels

enhancement Enhances existing behaviour or code new feature / API change New feature to be introduced or a change to the API (non suitable to minor releases)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baranowb @ropalka @fl4via