fix: fix PnP ESM loader integration (#255)

clemyan · web-flow · commit 4fb10bd12d5e · 2026-01-14T14:36:26.000+08:00
diff --git a/.changeset/honest-forks-juggle.md b/.changeset/honest-forks-juggle.md
@@ -0,0 +1,5 @@
+---
+"synckit": patch
+---
+
+Fix PnP ESM support
diff --git a/src/helpers.ts b/src/helpers.ts
@@ -24,7 +24,6 @@ import {
   INT32_BYTES,
   LOADER_FLAG,
   LOADER_FLAGS,
-  MODULE_REGISTER_SUPPORTED,
   MTS_SUPPORTED,
   NO_STRIP_TYPES,
   NO_STRIP_TYPES_FLAG,
@@ -313,9 +312,7 @@ export const setupTsRunner = (
         // absolute Windows paths in the --experimental-loader option.
         // https://github.com/un-ts/synckit/issues/123
         resolvedPnpLoaderPath = pathToFileURL(pnpLoaderPath).href
-        if (!MODULE_REGISTER_SUPPORTED) {
-          execArgv = [LOADER_FLAG, resolvedPnpLoaderPath, ...execArgv]
-        }
+        execArgv = [LOADER_FLAG, resolvedPnpLoaderPath, ...execArgv]
       }
     }
   }
diff --git a/src/index.ts b/src/index.ts
@@ -1,4 +1,3 @@
-import module from 'node:module'
 import path from 'node:path'
 import { fileURLToPath } from 'node:url'
 import {
@@ -7,7 +6,6 @@ import {
   workerData,
 } from 'node:worker_threads'
 
-import { MODULE_REGISTER_SUPPORTED } from './constants.js'
 import {
   extractProperties,
   overrideStdio,
@@ -107,12 +105,7 @@ export function runAsWorker<T extends AnyFn<Promise<R> | R>, R = ReturnType<T>>(
 
   overrideStdio(stdio)
 
-  const { workerPort, sharedBufferView, pnpLoaderPath } =
-    workerData as WorkerData
-
-  if (pnpLoaderPath && MODULE_REGISTER_SUPPORTED) {
-    module.register(pnpLoaderPath)
-  }
+  const { workerPort, sharedBufferView } = workerData as WorkerData
 
   parentPort!.on(
     'message',

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"synckit": patch
 +---
++
 +Fix PnP ESM support
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@ import {`
`24`	`24`	`INT32_BYTES,`
`25`	`25`	`LOADER_FLAG,`
`26`	`26`	`LOADER_FLAGS,`
`27`		`- MODULE_REGISTER_SUPPORTED,`
`28`	`27`	`MTS_SUPPORTED,`
`29`	`28`	`NO_STRIP_TYPES,`
`30`	`29`	`NO_STRIP_TYPES_FLAG,`
`@@ -313,9 +312,7 @@ export const setupTsRunner = (`
`313`	`312`	`// absolute Windows paths in the --experimental-loader option.`
`314`	`313`	`// https://github.com/un-ts/synckit/issues/123`
`315`	`314`	`resolvedPnpLoaderPath = pathToFileURL(pnpLoaderPath).href`
`316`		`- if (!MODULE_REGISTER_SUPPORTED) {`
`317`		`- execArgv = [LOADER_FLAG, resolvedPnpLoaderPath, ...execArgv]`
`318`		`- }`
	`315`	`+ execArgv = [LOADER_FLAG, resolvedPnpLoaderPath, ...execArgv]`
`319`	`316`	`}`
`320`	`317`	`}`
`321`	`318`	`}`