feat(prettier-plugin-sh): ✨ support zsh dialect via sh-syntax@^0.6.0 by jjloneman · Pull Request #512 · un-ts/prettier

jjloneman · 2026-07-09T20:23:17Z

🤖 Disclaimer: I had Claude help me generate this description.

🎯 Summary

Adds zsh dialect support to prettier-plugin-sh by upgrading sh-syntax to ^0.6.0.
Valid zsh such as ${0:A:h:h} (parameter modifier chains) previously failed with ternary operator missing ? before :; it now formats correctly under the new zsh variant.
Closes [prettier-plugin-sh] ⬆️ support zsh dialect by upgrading sh-syntax to 0.6.0 #511.

🔗 Upstream

Depends on [email protected], which rebuilds the WASM against mvdan/sh v3.13.1 and exposes a LangZsh variant.
sh-syntax issue: [bug] 🐛 valid zsh errors with ternary operator missing ? before : — vendored mvdan/sh version has no zsh dialect sh-syntax#135
sh-syntax fix PR: feat: ✨ add zsh dialect support (rebuild wasm against mvdan/sh v3.13.1) sh-syntax#136

🛠️ Changes

Dependency: bump sh-syntax ^0.5.8 → ^0.6.0 (packages/sh/package.json, yarn.lock).
Option: add LangVariant.LangZsh to the variant option choices in packages/sh/src/index.ts.
- Without it, Prettier rejects the value with Invalid variant value. Expected 1, 2, 4, 8 or 32, but received 16.
Test: add packages/sh/test/zsh.spec.ts covering the LangZsh constant and formatting of a zsh modifier chain.
Tests (upstream wording): mvdan/sh v3.13 now backtick-quotes tokens in parse errors, so:
- test/error.spec.ts: encountered ) → encountered `)`
- test/__snapshots__/fixtures.spec.ts.snap (445.sh): closing quote ' → closing quote `'`
Changeset: minor bump for prettier-plugin-sh.

✅ Verification

yarn build ✅
yarn lint:es ✅
yarn lint:tsc ✅
yarn test ✅ (83/83)
Manual check: foo(){ echo ${1:t}; } → foo() { echo ${1:t}; }, ${0:A:h:h} preserved.

📝 Notes

The LangVariant numeric values changed upstream (now 1 << iota bit flags), but this plugin references the exported constants, so no numeric values are hard-coded here.
No new file type/extension is registered — this only adds the zsh parser variant — so the generated languages.ts is unaffected.

Summary by CodeRabbit

New Features
- Added support for the Zsh shell dialect in shell formatting.
Bug Fixes
- Improved handling of Zsh-style modifier chains so they format correctly.
- Updated an error message expectation to match the latest output formatting.

Closes un-ts#511

changeset-bot · 2026-07-09T20:23:22Z

🦋 Changeset detected

Latest commit: ad408bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
prettier-plugin-sh	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-07-09T20:23:43Z

📝 Walkthrough

Walkthrough

Upgrades the sh-syntax dependency to ^0.6.0 to support the zsh dialect, adds a LangZsh choice to the variant option in prettier-plugin-sh, updates a test's expected error message wording, and adds a new test file verifying zsh modifier-chain formatting.

Changes

Zsh dialect support

Layer / File(s)	Summary
Dependency upgrade and changeset `packages/sh/package.json`, `.changeset/gh-511-add-zsh-support.md`	Bumps `sh-syntax` from `^0.5.8` to `^0.6.0` and adds a patch changeset describing the zsh dialect support addition.
Expose LangZsh variant option `packages/sh/src/index.ts`	Adds a new `LangZsh` entry to the `variant.choices` array with a description and `value: LangVariant.LangZsh`, inserted between `LangBats` and `LangAuto`.
Test updates for new behavior `packages/sh/test/error.spec.ts`, `packages/sh/test/zsh.spec.ts`	Updates the expected parse error message to backtick-quote the unexpected token, and adds a new spec verifying `LangVariant.LangZsh` is defined and that formatting preserves `${0:A:h:h}` modifier chains.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: enhancement, feature

Suggested reviewers: JounQin

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	Core requirements are implemented, but the snapshot wording update cannot be verified because packages/sh/test/snapshots/fixtures.spec.ts.snap was excluded by !*/.snap.	Provide the excluded snapshot file or remove the path filter so the error-message update can be verified.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Out of Scope Changes check	✅ Passed	The changes stay focused on zsh support, dependency bumping, and related tests/metadata with no clear unrelated additions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately summarizes the main change: adding zsh dialect support through sh-syntax 0.6.0.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

sonarqubecloud · 2026-07-09T20:23:47Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codesandbox-ci · 2026-07-09T20:23:49Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

socket-security · 2026-07-09T20:23:55Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	sh-syntax@0.5.8 ⏵ 0.6.0	⁺¹		⁺¹	⁺⁷

View full report

codacy-production · 2026-07-09T20:25:00Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results

Complexity 0

Duplication 0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

jjloneman · 2026-07-09T20:36:10Z

I ran build and lint locally and it seemed to pass:

$ yarn build && echo "✅ build" && yarn lint && echo "✅ lint"

✅ build
✅ lint

@JounQin, would you mind running the CI actions? Thanks!

pkg-pr-new · 2026-07-10T04:37:47Z

Open in StackBlitz

prettier-plugin-autocorrect

npm i https://pkg.pr.new/prettier-plugin-autocorrect@512

prettier-plugin-pkg

npm i https://pkg.pr.new/prettier-plugin-pkg@512

prettier-plugin-sh

npm i https://pkg.pr.new/prettier-plugin-sh@512

prettier-plugin-sql

npm i https://pkg.pr.new/prettier-plugin-sql@512

prettier-plugin-toml

npm i https://pkg.pr.new/prettier-plugin-toml@512

commit: ad408bc

codecov · 2026-07-10T04:38:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.28%. Comparing base (4323d8c) to head (ad408bc).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #512   +/-   ##
=======================================
  Coverage   87.28%   87.28%           
=======================================
  Files          10       10           
  Lines         236      236           
  Branches       66       66           
=======================================
  Hits          206      206           
  Misses         29       29           
  Partials        1        1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

feat(prettier-plugin-sh): ✨ support zsh dialect via sh-syntax@^0.6.0

ad408bc

Closes un-ts#511

JounQin approved these changes Jul 10, 2026

View reviewed changes

JounQin merged commit 733fcfd into un-ts:master Jul 10, 2026
25 checks passed

JounQin mentioned this pull request Jul 10, 2026

chore: release package(s) #513

Merged

Navigation Menu

Repository navigation

feat(prettier-plugin-sh): ✨ support zsh dialect via sh-syntax@^0.6.0 - #512

feat(prettier-plugin-sh): ✨ support zsh dialect via sh-syntax@^0.6.0#512
JounQin merged 1 commit into
un-ts:masterfrom
jjloneman:feature/gh-511-add-zsh-support-prettier-plugin-sh

jjloneman commented Jul 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Jul 9, 2026

Uh oh!

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 inconclusive)

Uh oh!

sonarqubecloud Bot commented Jul 9, 2026

Uh oh!

codesandbox-ci Bot commented Jul 9, 2026

Uh oh!

socket-security Bot commented Jul 9, 2026

Uh oh!

codacy-production Bot commented Jul 9, 2026

Uh oh!

jjloneman commented Jul 9, 2026

Uh oh!

pkg-pr-new Bot commented Jul 10, 2026

Uh oh!

codecov Bot commented Jul 10, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jjloneman commented Jul 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Summary

🔗 Upstream

🛠️ Changes

✅ Verification

📝 Notes

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Jul 9, 2026

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 inconclusive)

Uh oh!

sonarqubecloud Bot commented Jul 9, 2026

Quality Gate passed

Uh oh!

codesandbox-ci Bot commented Jul 9, 2026

Uh oh!

socket-security Bot commented Jul 9, 2026

Uh oh!

codacy-production Bot commented Jul 9, 2026

Up to standards ✅

Uh oh!

jjloneman commented Jul 9, 2026

Uh oh!

pkg-pr-new Bot commented Jul 10, 2026

Uh oh!

codecov Bot commented Jul 10, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jjloneman commented Jul 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading