Fix compatibility with laravel/framework#49231#82
Merged
pvsaintpe merged 1 commit intoumbrellio:masterfrom Dec 21, 2023
mpyw:fix/has-view-compatibility
Merged
Fix compatibility with laravel/framework#49231#82pvsaintpe merged 1 commit intoumbrellio:masterfrom mpyw:fix/has-view-compatibility
pvsaintpe merged 1 commit intoumbrellio:masterfrom
mpyw:fix/has-view-compatibility
Conversation
mpyw
commented
Dec 6, 2023
Comment on lines
31
to
32
|
|
||
| public function hasView(string $view): bool | ||
| public function hasView($view): bool | ||
| { |
Contributor
Author
There was a problem hiding this comment.
Argument types must NOT be narrowed, whereas return types can be narrowed.
Contributor
Author
|
Hi, Umbrellio Teams @tycooon Please review the pull-request, this is such an important fix. I'll appreciate for your help. |
pvsaintpe
approved these changes
Dec 21, 2023
This was referenced Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Umbrellio\Postgres\Schema\Builder::hasView(string $view): boolmust be compatible withIlluminate\Database\Schema\Builder::hasView($view)#81