Add optional pattern to filter file types.#4
Merged
duarten merged 2 commits intoumani:masterfrom Mar 25, 2020
Merged
Conversation
duarten
requested changes
Mar 7, 2020
Member
duarten
left a comment
duarten
left a comment
There was a problem hiding this comment.
Thanks for the PR! :D Looks good in general, I just have a small comment.
Contributor
Author
|
@duarten I added a conditional to check the renamed file. What do you think? |
Member
|
@robdodson Looks great, thanks! |
duarten
pushed a commit
that referenced
this pull request
Mar 25, 2020
I really like this action, but I've found that I often want to filter the outputs that it produces and hand them to other tasks such as linters. This PR adds an optional pattern input which is a regex that defaults to .* that can be used to filter the files that end up in each array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really like this action, but I've found that I often want to filter the outputs that it produces and hand them to other tasks such as linters. This PR adds an optional
patterninput which is a regex that defaults to.*that can be used to filter the files that end up in each array.I haven't been able to build and test the changes so, if you like the PR, you might need to try it against a test project.