Repository navigation
Keep commas in search filter values - #4496
Merged
mikecao merged 2 commits intoSep 11, 2026
Merged
Conversation
|
@justadityaraj is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThe PR preserves comma-bearing values for search operators and resynchronizes selected filter state when the operator or value changes.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/components/common/FilterRecord.tsx | Adds operator-aware selected-value initialization and prop synchronization, resolving the previously reported stale split state. |
| src/components/common/FilterRecord.test.tsx | Covers comma preservation both on initial rendering and when transitioning from a multi-value operator to regex. |
Reviews (2): Last reviewed commit: "fix(filters): sync values when operators..." | Re-trigger Greptile
Member
mikecao
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Editing a search filter initialized every string value by splitting on commas. Regex quantifiers such as
{21,22}were therefore truncated in the input even though the URL parser had preserved the full expression.Fix
Keep search-operator values as one string when initializing
FilterRecord; retain comma splitting for the existing multi-value operators. Add a component regression using the reported regex shape.User impact
Regex, contains, and other free-text filter values containing commas remain fully visible and editable instead of showing only the prefix before the first comma.
Verification
tsc --noEmitpassed after generating the Prisma client with a placeholder local database URL.git diff --checkpassed.Fixes #4489
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.