Skip to content

Add support for Python 3.11 and PyPy3.9#564

Merged
hugovk merged 5 commits intoultrajson:mainfrom
hugovk:add-3.11
Sep 15, 2022
Merged

Add support for Python 3.11 and PyPy3.9#564
hugovk merged 5 commits intoultrajson:mainfrom
hugovk:add-3.11

Conversation

@hugovk
Copy link
Copy Markdown
Member

@hugovk hugovk commented Sep 14, 2022

Changes proposed in this pull request:

  • Support Python 3.11:
    • add Trove classifier
    • test on CI
    • build wheel
  • Create wheel for PyPy3.9

Python 3.11 is currently at release candidate 2, the last one before full release on 2022-10-24, and includes this call to action:

Community members
We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.11 compatibilities during this phase. As always, report any issues to the Python bug tracker 1.

And:

There will be no ABI changes from this point forward in the 3.11 series and the goal is that there will be as few code changes as possible.

So it is pretty safe to release a 3.11 release now. We can label it as a dev preview, and put also out a new release when 3.11.0 is out.

But also, if you'd prefer to wait until the full 3.11.0 release, that's fine too, we've not yet had anyone asking for 3.11 wheels yet.

Also in this PR:

  • Bump GitHub Actions versions
  • GHA: Use ubuntu-latest, except pin to latest 22.04 for the benchmarking

@hugovk hugovk added the changelog: Added For new features label Sep 14, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 14, 2022 •
edited by codecov Bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.58%. Comparing base (203f311) to head (b5ce312).
⚠️ Report is 206 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files           6        6           
  Lines        1901     1902    +1     
=======================================
+ Hits         1741     1742    +1     
  Misses        160      160

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bwoodsend
bwoodsend approved these changes Sep 14, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RC2 is close enough to the real thing for me. Bombs away...

JustAnotherArchivist
JustAnotherArchivist approved these changes Sep 14, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@JustAnotherArchivist JustAnotherArchivist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal release without a dev preview mark or similar sounds good to me.
Other changes look fine as well, thanks!

@JustAnotherArchivist
Copy link
Copy Markdown
Collaborator

JustAnotherArchivist commented Sep 14, 2022

I'm getting a red X for the CI on b5ce312 for whatever reason even though all checks passed. Just GitHub Actions being weird?

@bwoodsend
Copy link
Copy Markdown
Collaborator

bwoodsend commented Sep 14, 2022

A red X which, if you click on it, creates a popup showing that all 36 checks passed. 🙄 Is it just me or is GH's web UI getting buggier and buggier...

@hugovk
Copy link
Copy Markdown
Member Author

hugovk commented Sep 15, 2022

I think the red X is because I added the "changelog" label after creating the PR:

image

So the "Require PR label" action failed, as expected. Then I added it, and it re-ran, and passed, as expected:

image

But it makes no sense to still show the red X if it later passed... 🤷

@hugovk hugovk merged commit d84c832 into ultrajson:main Sep 15, 2022
@hugovk hugovk deleted the add-3.11 branch September 15, 2022 11:22
@hugovk
Copy link
Copy Markdown
Member Author

hugovk commented Sep 15, 2022

OK, all good to release with these release notes?

image

https://github.com/ultrajson/ultrajson/releases

@bwoodsend
Copy link
Copy Markdown
Collaborator

bwoodsend commented Sep 15, 2022

Yay! I did something in this one 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JustAnotherArchivist JustAnotherArchivist JustAnotherArchivist approved these changes

@bwoodsend bwoodsend bwoodsend approved these changes

Assignees

No one assigned

Labels

changelog: Added For new features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugovk @codecov-commenter @JustAnotherArchivist @bwoodsend