Skip to content

Reduce CI matrix: test Ubuntu on all Pythons, and the others on a single Python#547

Merged
hugovk merged 3 commits intoultrajson:mainfrom
hugovk:update-test-matrix
Jun 2, 2022
Merged

Reduce CI matrix: test Ubuntu on all Pythons, and the others on a single Python#547
hugovk merged 3 commits intoultrajson:mainfrom
hugovk:update-test-matrix

Conversation

@hugovk
Copy link
Copy Markdown
Member

@hugovk hugovk commented Jun 2, 2022

Fixes #546.

Changes proposed in this pull request:

  • Test Ubuntu with all Python versions
  • And test Windows and macOS with a single Python version
  • Also remove a stray print from a test

Before

23 jobs

image

After

8 jobs

image

@hugovk hugovk added testing Unit tests, linting, CI, etc. changelog: skip Exclude PR from release draft labels Jun 2, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 2, 2022 •
edited by codecov Bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.59%. Comparing base (f71d7c2) to head (eec8eb4).
⚠️ Report is 248 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   91.68%   91.59%   -0.10%     
==========================================
  Files           6        6              
  Lines        1828     1808      -20     
==========================================
- Hits         1676     1656      -20     
  Misses        152      152

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugovk hugovk marked this pull request as draft June 2, 2022 14:33
@hugovk
Copy link
Copy Markdown
Member Author

hugovk commented Jun 2, 2022

Will refactor these required checks too.

image

@hugovk
Copy link
Copy Markdown
Member Author

hugovk commented Jun 2, 2022

Now instead of individually marking jobs as required in the branch protection (which is tedious when adding or removing):

https://github.com/ultrajson/ultrajson/settings/branch_protection_rules/19228702

image

Just require a final noop job that depends on the others:

image

So:

image

And:

image

@hugovk hugovk marked this pull request as ready for review June 2, 2022 14:48
bwoodsend
bwoodsend approved these changes Jun 2, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bwoodsend bwoodsend left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now instead of individually marking jobs as required in the branch protection (which is tedious when adding or removing):

You'd really think that they'd be grouped by workflow or have a select all button.

@hugovk hugovk merged commit 4ac30c9 into ultrajson:main Jun 2, 2022
@hugovk hugovk deleted the update-test-matrix branch June 2, 2022 18:27
@hugovk hugovk mentioned this pull request Jun 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoodsend bwoodsend bwoodsend approved these changes

Assignees

No one assigned

Labels

changelog: skip Exclude PR from release draft testing Unit tests, linting, CI, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI review: OS versions

3 participants

@hugovk @codecov-commenter @bwoodsend