Fix reference counting bug for dict values#353
Merged
hugovk merged 1 commit intoultrajson:masterfrom Mar 3, 2020
Merged
Conversation
Member
|
@richafrank Please could you resolve the merge conflict? |
which meant a memory leak. PyObject_GetItem returns a new reference (and goes through abstract object[key] API), whereas PyDict_GetItem returns a borrowed reference and goes directly to the dict hash lookup.
richafrank
force-pushed
the
dict-val-mem-leak
branch
from
3a2e3bd to
36089a5
Compare
Contributor
Author
Done! I also re-did the test to match the style of those added in #270. (They looked cleaner to me.) |
Member
|
Thank you! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which meant a memory leak.
PyObject_GetItem returns a new reference (and goes through
abstract object[key] API), whereas PyDict_GetItem returns a borrowed
reference and goes directly to the dict hash lookup.