Skip to content

Comments

Add IPv6 support to NFLOG#1375

Merged
ukanth merged 2 commits intoukanth:betafrom
NeroProtagonist:nflogIPv6
Mar 4, 2024
Merged

Add IPv6 support to NFLOG#1375
ukanth merged 2 commits intoukanth:betafrom
NeroProtagonist:nflogIPv6

Conversation

@NeroProtagonist
Copy link
Contributor

@NeroProtagonist NeroProtagonist commented Mar 2, 2024

As in title, Nflog can now decode and print IPv6 + TCP/UDP/ICMPv6 packets.
Also updated all builds to use API 21 (latest available on NDK10).

Tested on Pixel 4a (arm architecture).
Compiled binaries for the other platforms but can't test them.

@NeroProtagonist
All external binaries/platforms are now compiled with API 21.
0b5d4b6 
Added printing of IPv6 TCP/UDP/ICMPv6 packets with nflog.
@NeroProtagonist
Copy link
Contributor Author

NeroProtagonist commented Mar 2, 2024

Fixes #1232

ukanth
ukanth reviewed Mar 4, 2024
View reviewed changes
Copy link
Owner

@ukanth ukanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ukanth ukanth merged commit 7a0b8cf into ukanth:beta Mar 4, 2024
@selurvedu selurvedu mentioned this pull request Apr 8, 2024
Closed
@bsdice
Copy link

bsdice commented Apr 8, 2024

After xz backdooring, uploading binaries to a repo is seriously bad practice, imho.

Why is the x86 binary 4k bigger and the others only bytes?

@ukanth
Copy link
Owner

ukanth commented Apr 27, 2024

After xz backdooring, uploading binaries to a repo is seriously bad practice, imho.

Why is the x86 binary 4k bigger and the others only bytes?

I usually compile all the binaries from source and bundle it before releasing it to public.

@yashikada
Copy link

yashikada commented Oct 27, 2024

Why is the x86 binary 4k bigger and the others only bytes?

this happens because the arm architecture is more optimized than the x86 one, there are fewer instructions to do the same thing.
However you are absolutely right.

I usually compile all the binaries from source and bundle it

but this did not happen in this case. Are we sure that the author of this PR is reliable?
Wouldn't it be to have all the binaries compiled with github actions?

@linsui
Copy link
Contributor

linsui commented Mar 13, 2025

How is this built with api 21? Wait3 is not available in api 21 and the busybox build is fixed in 1.34.0 in mirror/busybox@c0943ac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ukanth ukanth ukanth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NeroProtagonist @bsdice @ukanth @yashikada @linsui