fix dns leak when using external dns client#1101
Merged
ukanth merged 1 commit intoukanth:betafrom May 23, 2020
jamazi:beta
Merged
fix dns leak when using external dns client#1101ukanth merged 1 commit intoukanth:betafrom jamazi:beta
ukanth merged 1 commit intoukanth:betafrom
jamazi:beta
Conversation
Owner
|
Instead of checking the state, would it make sense to add new option for external dns client ? |
Author
|
Isn't activating 'Disable DNS via netd' option responsible for that ? |
ukanth
approved these changes
May 23, 2020
Closed
intika
added a commit
to Intika-PR/afwall
that referenced
this pull request
Sep 19, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change all apps can make dns requests even when using dns client and disabling netd.