Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacement behavior of img tag - srcset attribute #558

Closed
mythnc opened this issue Sep 22, 2020 · 1 comment
Closed

Replacement behavior of img tag - srcset attribute #558

mythnc opened this issue Sep 22, 2020 · 1 comment
Assignees
@planv
Milestone
v3.1.0

Comments

@mythnc
Copy link

mythnc commented Sep 22, 2020

I am kind of curious to the replace behavior of srcset attribute in img tag.

When I chose Backup mode, and after synchronized, I found that the URL in src attribute is still WordPress URL, but the URLs in srcset attribute are replaced to gcp URLs in img tag

I think all URLs inside img tag should not been changed, because I chose Backup mode.

I tried to read source code and found that srcset urls will be replaced regardless of mode.

I am not sure this is an expected behavior or a bug?

ref:
https://github.com/udx/wp-stateless/blob/v3.0/lib/classes/class-bootstrap.php#L415
@planv planv self-assigned this Oct 6, 2020
planv added a commit that referenced this issue Oct 6, 2020
@planv
Replacement behavior of img tag - srcset attribute #558
d4ef9a4
@planv planv mentioned this issue Oct 6, 2020
Merged
@planv planv added this to the v3.1.0 milestone Oct 6, 2020
@planv
Copy link
Contributor

planv commented Oct 8, 2020

This is fixed in 3.1.0. We are going to release it at the nearest time.

@planv planv closed this as completed Oct 8, 2020
@antonkorotkov antonkorotkov mentioned this issue Oct 8, 2020
Merged
@ewsopp ewsopp added this to the v3.1.0 milestone Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@planv planv

Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

No branches or pull requests
3 participants
@mythnc @planv @ewsopp