Profile image no collapse#29
Conversation
mattxwang
left a comment
mattxwang
left a comment
There was a problem hiding this comment.
Hey Utsav,
This PR looks alright, but the implementation is a bit sketchy - we shouldn't rely on an outside image host (i.e. imgur) for any component of our site (what if imgur went down, adds an extra outside request, could mess with caching, etc.). I'd either download the image and put it into the public folder, or use some alternative (i.e. using Font Awesome or something else).
(also, I'm not sure how I feel about the absolute positioning stuff, but that's workable for now).
|
Alternatively, just leave the edit button as the word for now, and we can revisit this later - it's semi-important that we get this change through somewhat early. |
|
Merging this branch with the font-awesome branch... |
|
All changes of this branch are now in font-awesome branch. Merge that when complete to stable/master. |
|
Hey Utsav, You should avoid merging different feature branches into the same PR in the future - but since you've already made the changes, I'll allow it this time. |
|
Sorry! I though this was the quickest way to bring font awesome edit icon into this. |
|
Yeah, I understand that, and it's a bit tricky. In the future, you can remerge master back into this branch, use git cherry pick, or use a few other workarounds to make it all work out. |
2 participants
Profile photo now does not collapse and edit button is now edit icon.