Vertically centered aligned the radio buttons using line-heights#25
Merged
Conversation
utsavm9
changed the title
connorbo97
reviewed
Apr 12, 2019
connorbo97
left a comment
connorbo97
left a comment
Contributor
There was a problem hiding this comment.
Looks good for me, but I want a second opinion
mattxwang
approved these changes
Apr 12, 2019
mattxwang
left a comment
mattxwang
left a comment
Member
There was a problem hiding this comment.
Yeah, this works. I feel like we should probably do this with flexbox eventually (especially if you have variable sizes), but there are debates in and of itself of using flexbox. Plus, it works for now.
@connorbo97 maybe a 2.0 is refactoring a lot of our CSS to use newer CSS thingies (like CSS Grid, Flexbox, etc. - but looking at our browser support).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line-heights are hard-coded, but I do not think the size of the button changes anyways.