Repository navigation
[RDMA] Replace stale EQDS pull-target bits on retransmission - #1107
Merged
zhongjiechen merged 2 commits intoNov 3, 2026
Merged
Conversation
YangZhou1997
approved these changes
Nov 1, 2026
Member
zhongjiechen
approved these changes
Nov 3, 2026
Member
|
/run-benchmark l4 |
Benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1097.
EQDS retransmission decodes an existing work request's immediate data and calls
SetTarget()with a newly computed pull target. The setter previously ORed new bits into the old target: changing 127 to 128 encoded 255, and setting zero did not clear the old value.Clear the eight target bits before inserting the new value. Preserve FID, RID, CSN, HINT, and the existing truncation of input to eight bits.
Add
imm_data_test, picked up by the existing native Makefiles. It checks all 65,536 old/new target combinations through network-byte-order encode/decode, varies the remaining fields, and checks clearing and oversized inputs.Type of Change
How Has This Been Tested?
Linux x86-64 / GCC 13.3 / CUDA 12.8 headers, comparing upstream
54e216eeand this fix with the same test:param.cc: all checks pass, including leak checking.imm_data_test, all RDMA transport objects, andlibnccl-net-uccl.sopass for baseline and fix, using the repository's pinned NCCL headers (2ea4ee94). Because the host lacks the unused gflags/gtest libraries, usedLIBS="-lz -lelf -libverbs -L/usr/local/cuda-12.8/lib64 -lcudart -lpthread"andLIBS_SHARED="-lz -lelf -libverbs".git diff --check.The test executes the production immediate-data types without a device or remote host. Live packet-loss/retransmission traffic and throughput were not measured. This affects EQDS when enabled; the default receiver-CCA configuration is unchanged.
Checklist
format.shto follow the style guidelines. (Ran clang-format 14 directly on the changed files.)build.shto verify compilation. (Used native Makefile builds above.)