Repository navigation
fix: bundle and fallback to Noto Sans CJK for missing Chinese glyphs - #2182
Merged
Merged
Conversation
Flutter has a known issue on ARM64 Linux platforms (flutter/flutter#90951) where Chinese glyphs fail to render and display as tofu (□□□). Ahead of the upstream release for the Lenovo partnership, this provides a workaround for App Center: - Add Noto Sans CJK (SC, TC, HK) to fontFamilyFallback - Stage fonts-noto-cjk in snapcraft.yaml for glyph coverage inside snap confinement UDENG-11262 Signed-off-by: Murad Eynizada <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flutter has a known issue on ARM64 Linux platforms (flutter/flutter#90951) where Chinese glyphs fail to render and display as tofu boxes (
□□□). Within snap confinement, the application lacks access to necessary CJK glyph tables, causing unrendered characters across the interface.Ahead of an upstream release for the Lenovo partnership, this provides a workaround in App Center by bundling the fonts and declaring explicit fallbacks.
Changes
Add Noto Sans CJK to font fallbacks — In
packages/app_center/lib/store/store_app.dart(insideStoreAppThemeX), addedNoto Sans CJK (SC, TC, HK)tofontFamilyFallback.Stage CJK fonts in the snap — Added
fonts-noto-cjktostage-packagesinsnapcraft.yamlso the required font files are bundled and accessible inside snap confinement at runtime.Testing
Manual verification on ARM64 hardware:
LANG=zh_CN.UTF-8).UDENG-11262