include default path for bindiff on windows (#36)

bukowa · web-flow · commit d33a538dc317 · 2025-02-14T08:28:33.000+01:00
diff --git a/src/main/java/bindiffhelper/BinDiffHelperPlugin.java b/src/main/java/bindiffhelper/BinDiffHelperPlugin.java
@@ -63,8 +63,8 @@ public class BinDiffHelperPlugin extends ProgramPlugin {
 	Exporter binExportExporter;
 	String binDiffBinary;
 	String diffCommand;
+	protected String defaultBinPath;
 	protected String defaultDiffCommand;
-	
 	Program program;
 	
 	public final static String BDBINPROPERTY = "de.ubfx.bindiffhelper.bindiffbinary";
@@ -103,12 +103,15 @@ public BinDiffHelperPlugin(PluginTool tool) {
 		}
 
 		if (System.getProperty("os.name").toLowerCase().contains("win")) {
+			defaultBinPath = "C:\\Program Files\\BinDiff\\bin\\bindiff.exe";
 			defaultDiffCommand = "notepad++ -multiInst -nosession -lc -pluginMessage=compare \"$file1\" \"$file2\"";
 		}
 		if (System.getProperty("os.name").toLowerCase().contains("nix")) {
+			// defaultBinPath = "/opt/bindiff/bin/bindiff";
 			defaultDiffCommand = "x-terminal-emulator -e 'diff -u \"$file1\" \"$file2\"'";
 		}
 
+		binDiffBinary = Preferences.getProperty(BDBINPROPERTY, defaultBinPath);
 		diffCommand = Preferences.getProperty(DIFFCOMMAND, defaultDiffCommand);
 		
 		provider = new BinDiffHelperProvider(this, this.getCurrentProgram());
