chore: remove redundant arg from logln (#1136)

sashamelentyev · web-flow · commit d6ce3b9b2834 · 2022-07-22T08:58:28.000-07:00
logln takes a redundant "template" argument that's never used.
This was likely modeled after the existing `log(..)` method
which does use its template argument.
diff --git a/sugar.go b/sugar.go
@@ -231,38 +231,38 @@ func (s *SugaredLogger) Fatalw(msg string, keysAndValues ...interface{}) {
 
 // Debugln uses fmt.Sprintln to construct and log a message.
 func (s *SugaredLogger) Debugln(args ...interface{}) {
-	s.logln(DebugLevel, "", args, nil)
+	s.logln(DebugLevel, args, nil)
 }
 
 // Infoln uses fmt.Sprintln to construct and log a message.
 func (s *SugaredLogger) Infoln(args ...interface{}) {
-	s.logln(InfoLevel, "", args, nil)
+	s.logln(InfoLevel, args, nil)
 }
 
 // Warnln uses fmt.Sprintln to construct and log a message.
 func (s *SugaredLogger) Warnln(args ...interface{}) {
-	s.logln(WarnLevel, "", args, nil)
+	s.logln(WarnLevel, args, nil)
 }
 
 // Errorln uses fmt.Sprintln to construct and log a message.
 func (s *SugaredLogger) Errorln(args ...interface{}) {
-	s.logln(ErrorLevel, "", args, nil)
+	s.logln(ErrorLevel, args, nil)
 }
 
 // DPanicln uses fmt.Sprintln to construct and log a message. In development, the
 // logger then panics. (See DPanicLevel for details.)
 func (s *SugaredLogger) DPanicln(args ...interface{}) {
-	s.logln(DPanicLevel, "", args, nil)
+	s.logln(DPanicLevel, args, nil)
 }
 
 // Panicln uses fmt.Sprintln to construct and log a message, then panics.
 func (s *SugaredLogger) Panicln(args ...interface{}) {
-	s.logln(PanicLevel, "", args, nil)
+	s.logln(PanicLevel, args, nil)
 }
 
 // Fatalln uses fmt.Sprintln to construct and log a message, then calls os.Exit.
 func (s *SugaredLogger) Fatalln(args ...interface{}) {
-	s.logln(FatalLevel, "", args, nil)
+	s.logln(FatalLevel, args, nil)
 }
 
 // Sync flushes any buffered log entries.
@@ -285,7 +285,7 @@ func (s *SugaredLogger) log(lvl zapcore.Level, template string, fmtArgs []interf
 }
 
 // logln message with Sprintln
-func (s *SugaredLogger) logln(lvl zapcore.Level, template string, fmtArgs []interface{}, context []interface{}) {
+func (s *SugaredLogger) logln(lvl zapcore.Level, fmtArgs []interface{}, context []interface{}) {
 	if lvl < DPanicLevel && !s.base.Core().Enabled(lvl) {
 		return
 	}

Original file line number	Diff line number	Diff line change
`@@ -231,38 +231,38 @@ func (s *SugaredLogger) Fatalw(msg string, keysAndValues ...interface{}) {`
`231`	`231`
`232`	`232`	`// Debugln uses fmt.Sprintln to construct and log a message.`
`233`	`233`	`func (s *SugaredLogger) Debugln(args ...interface{}) {`
`234`		`- s.logln(DebugLevel, "", args, nil)`
	`234`	`+ s.logln(DebugLevel, args, nil)`
`235`	`235`	`}`
`236`	`236`
`237`	`237`	`// Infoln uses fmt.Sprintln to construct and log a message.`
`238`	`238`	`func (s *SugaredLogger) Infoln(args ...interface{}) {`
`239`		`- s.logln(InfoLevel, "", args, nil)`
	`239`	`+ s.logln(InfoLevel, args, nil)`
`240`	`240`	`}`
`241`	`241`
`242`	`242`	`// Warnln uses fmt.Sprintln to construct and log a message.`
`243`	`243`	`func (s *SugaredLogger) Warnln(args ...interface{}) {`
`244`		`- s.logln(WarnLevel, "", args, nil)`
	`244`	`+ s.logln(WarnLevel, args, nil)`
`245`	`245`	`}`
`246`	`246`
`247`	`247`	`// Errorln uses fmt.Sprintln to construct and log a message.`
`248`	`248`	`func (s *SugaredLogger) Errorln(args ...interface{}) {`
`249`		`- s.logln(ErrorLevel, "", args, nil)`
	`249`	`+ s.logln(ErrorLevel, args, nil)`
`250`	`250`	`}`
`251`	`251`
`252`	`252`	`// DPanicln uses fmt.Sprintln to construct and log a message. In development, the`
`253`	`253`	`// logger then panics. (See DPanicLevel for details.)`
`254`	`254`	`func (s *SugaredLogger) DPanicln(args ...interface{}) {`
`255`		`- s.logln(DPanicLevel, "", args, nil)`
	`255`	`+ s.logln(DPanicLevel, args, nil)`
`256`	`256`	`}`
`257`	`257`
`258`	`258`	`// Panicln uses fmt.Sprintln to construct and log a message, then panics.`
`259`	`259`	`func (s *SugaredLogger) Panicln(args ...interface{}) {`
`260`		`- s.logln(PanicLevel, "", args, nil)`
	`260`	`+ s.logln(PanicLevel, args, nil)`
`261`	`261`	`}`
`262`	`262`
`263`	`263`	`// Fatalln uses fmt.Sprintln to construct and log a message, then calls os.Exit.`
`264`	`264`	`func (s *SugaredLogger) Fatalln(args ...interface{}) {`
`265`		`- s.logln(FatalLevel, "", args, nil)`
	`265`	`+ s.logln(FatalLevel, args, nil)`
`266`	`266`	`}`
`267`	`267`
`268`	`268`	`// Sync flushes any buffered log entries.`
`@@ -285,7 +285,7 @@ func (s *SugaredLogger) log(lvl zapcore.Level, template string, fmtArgs []interf`
`285`	`285`	`}`
`286`	`286`
`287`	`287`	`// logln message with Sprintln`
`288`		`-func (s *SugaredLogger) logln(lvl zapcore.Level, template string, fmtArgs []interface{}, context []interface{}) {`
	`288`	`+func (s *SugaredLogger) logln(lvl zapcore.Level, fmtArgs []interface{}, context []interface{}) {`
`289`	`289`	`if lvl < DPanicLevel && !s.base.Core().Enabled(lvl) {`
`290`	`290`	`return`
`291`	`291`	`}`