Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: uber-go/goleak
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.12
Choose a base ref
...
head repository: uber-go/goleak
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.2.1
Choose a head ref
  • 16 commits
  • 15 files changed
  • 9 contributors

Commits on Mar 15, 2022

  1. CI: test with Go 1.17 and 1.18 (#73)

    We only support the two most recent minor releases.
    abhinav authored Mar 15, 2022
    Configuration menu
    Copy the full SHA
    ebabc7b View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Configuration menu
    Copy the full SHA
    fe3486f View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Use Go 1.19 (#76)

    sywhang authored Aug 18, 2022
    Configuration menu
    Copy the full SHA
    4e045fd View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Mark VerifyNone as a test Helper (#75)

    Mark `VerifyNone(...)` as a test `Helper` function, so that it reports the error at the call site, rather than `leaks.go:78:`.
    
    From the [go docs](https://pkg.go.dev/testing#T.Helper):
    
    > Helper marks the calling function as a test helper function. When printing file and line information, that function will be skipped. Helper may be called simultaneously from multiple goroutines.
    
    This is useful for tests that verify go routines at multiple points, so failures can be more easily distinguished.
    tallclair authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    2dfebe8 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Cleanup dead code (#79)

    sywhang authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    326e1c1 View commit details
    Browse the repository at this point in the history
  2. Add Cleanup option (#78)

    This adds Cleanup option which can be passed to VerifyTestMain and
    VerifyNone. This takes in a function that will be executed at the
    end of the leak verification.
    
    Internal Ref: GO-888
    Fix #63
    
    Co-authored-by: Abhinav Gupta <[email protected]>
    Co-authored-by: Abhinav Gupta <[email protected]>
    3 people authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    704c76c View commit details
    Browse the repository at this point in the history
  3. Update testify and cleanup (#81)

    This updates testify dependency to v1.8.0 (most recent version) and
    cleans up some tests using new APIs.
    sywhang authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    b3e1892 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Prepare release v1.2.0 (#82)

    Co-authored-by: Abhinav Gupta <[email protected]>
    sywhang and abhinav authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    5c9bf00 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Remove mentions of Go 1.5 compatibility from Readme (#86)

    Fixes #85
    
    We're no longer compatible with pre 1.16  since #79.
    
    I'm opting for removing the version rather than updating it to 1.18
    since we already have go.mod for this.
    
    Adding a pointer to the Go release policy, but I also considered
    dropping the mentions altogether. Copied the copy from `zap`.
    rabbbit authored Dec 16, 2022
    Configuration menu
    Copy the full SHA
    3465299 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Update: version 0.10.0 link (#90)

    update version 0.10.0 link in CHANGELOG.md
    ashishsinghin authored Jan 20, 2023
    Configuration menu
    Copy the full SHA
    70e025e View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Move tools dependencies into subdirectory with tag (#96)

    Fixes #92.
    
    Avoid tools dependencies in goleak's go.mod.
    
    golint is deprecated, we can separately migrate to another tool, but the
    tools change avoids any CI-time dependency from leaking into our go.mod.
    prashantv authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    1649ce4 View commit details
    Browse the repository at this point in the history
  2. tools: Switch golint to revive

    Revive is a drop-in replacement for golint that's faster.
    
    Setting up a basic configuration that we can be tweaked going forward.
    prashantv committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    f4fcc81 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d8227cf View commit details
    Browse the repository at this point in the history
  4. tools: Switch golint to revive (#97)

    Follow-up to #92.
    
    Revive is a drop-in replacement for golint that's faster.
    
    Setting up a basic configuration that we can be tweaked going forward.
    moisesvega authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    1f9f3ff View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2023

  1. Test against go1.20 (drop 1.17 and 1.18).. (#98)

    As part of this change, also upgrade the actions to the latest major
    versions.
    
    This also fixes a typo in the tools/go.mod.
    prashantv authored Feb 12, 2023
    Configuration menu
    Copy the full SHA
    69e02ef View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Release v1.2.1 (#100)

    This release is a patch release that removes golang/x/lint dependency.
    
    Ref #99.
    sywhang authored Feb 13, 2023
    Configuration menu
    Copy the full SHA
    83c7e12 View commit details
    Browse the repository at this point in the history
Loading