Skip to content

Use exact match for QID#31

Merged
simon-moo merged 1 commit intomasterfrom
henry.wu/qid_regex_fix
Oct 14, 2020
Merged

Use exact match for QID#31
simon-moo merged 1 commit intomasterfrom
henry.wu/qid_regex_fix

Conversation

@simon-moo
Copy link
Copy Markdown
Contributor

@simon-moo simon-moo commented Oct 14, 2020

Go's MatchString is not exact match, more like ContainString. This PR is to fix it.

fix #30

@simon-moo simon-moo self-assigned this Oct 14, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2020

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #31    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           14        14            
  Lines         1461      1279   -182     
==========================================
- Hits          1461      1279   -182     
Impacted Files Coverage Δ
go/utils.go 100.00% <ø> (ø)
go/wg.go 100.00% <0.00%> (ø)
go/cost.go 100.00% <0.00%> (ø)
go/rows.go 100.00% <0.00%> (ø)
go/trace.go 100.00% <0.00%> (ø)
go/wgtag.go 100.00% <0.00%> (ø)
go/config.go 100.00% <0.00%> (ø)
go/driver.go 100.00% <0.00%> (ø)
go/result.go 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb4a0b...037f073. Read the comment docs.

@simon-moo simon-moo merged commit 0c97c85 into master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL go to QID branch when query has uuid-type string in it

1 participant