Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #885 +/- ##
============================================
+ Coverage 87.09% 87.18% +0.09%
- Complexity 1940 1950 +10
============================================
Files 77 77
Lines 6267 6274 +7
Branches 1218 1219 +1
============================================
+ Hits 5458 5470 +12
Misses 405 405
+ Partials 404 399 -5 ☔ View full report in Codecov by Sentry. |
yuxincs
approved these changes
Dec 26, 2023
Collaborator
yuxincs
left a comment
yuxincs
left a comment
There was a problem hiding this comment.
PR LGTM, I only have a few questions/nits :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #877