Suggest castToNonNull fix for unboxing error#1182
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1182 +/- ##
=========================================
Coverage 88.21% 88.21%
Complexity 2312 2312
=========================================
Files 88 88
Lines 7550 7550
Branches 1511 1511
=========================================
Hits 6660 6660
Misses 446 446
Partials 444 444 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuxincs
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is true that if such an inserted cast ever fails, the program will fail immediately after with an NPE (in the case that the cast method doesn't fail fast). Still, it's worthwhile to support this, to enable narrower automated suppressions of these warnings.