Don't treat @ParametricNullness as @Nullable in JSpecify mode#1174
Merged
Don't treat @ParametricNullness as @Nullable in JSpecify mode#1174
@ParametricNullness as @Nullable in JSpecify mode#1174Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1174 +/- ##
============================================
+ Coverage 88.19% 88.22% +0.02%
- Complexity 2310 2311 +1
============================================
Files 88 88
Lines 7539 7541 +2
Branches 1508 1510 +2
============================================
+ Hits 6649 6653 +4
+ Misses 446 445 -1
+ Partials 444 443 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuxincs
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1173
In JSpecify mode, we should rely on our checking of generic types and not treat
@ParametricNullnessas a@Nullableannotation.