JSpecify: properly handle lambdas in anonymous inner classes#1165
Merged
JSpecify: properly handle lambdas in anonymous inner classes#1165
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1165 +/- ##
=========================================
Coverage 88.17% 88.17%
- Complexity 2303 2305 +2
=========================================
Files 88 88
Lines 7533 7536 +3
Branches 1505 1506 +1
=========================================
+ Hits 6642 6645 +3
Misses 448 448
Partials 443 443 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuxincs
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1156
When checking correctness of lambda overrides we get the type from
javac's inferred type rather than using the enclosing class. Also, when getting the type of an anonymous class we add some extra assertions to ensure we find the rightNewClassTreerepresenting the anonymous class. I think we'll always get the right tree now, but the asserts give peace of mind.