Add flag to indicate only @NullMarked code should be checked#1117
Merged
Add flag to indicate only @NullMarked code should be checked#1117
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1117 +/- ##
============================================
+ Coverage 88.14% 88.17% +0.03%
- Complexity 2234 2238 +4
============================================
Files 85 85
Lines 7237 7239 +2
Branches 1439 1439
============================================
+ Hits 6379 6383 +4
+ Misses 431 430 -1
+ Partials 427 426 -1 ☔ View full report in Codecov by Sentry. |
yuxincs
approved these changes
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #574
We add a new flag
OnlyNullMarkedto indicate that NullAway can only check code that is@NullMarked, and hence it is ok to omit the (previously required)AnnotatedPackagesflag. We currently require exactly one of eitherAnnotatedPackagesorOnlyNullMarkedto be passed in; if both flags are omitted or both flags are passed, we fail.As JSpecify and
@NullMarkedbecome more widely adopted, we may change the policy to allow neither flag to be passed (as NullAway already checks@NullMarkedcode out of the box). But for now, we require one of the flags to be passed, to avoid confusion.