Properly handle nested generics and multiple wildcard type args in JarInfer#1114
Merged
Properly handle nested generics and multiple wildcard type args in JarInfer#1114
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1114 +/- ##
============================================
+ Coverage 88.12% 88.13% +0.01%
- Complexity 2221 2229 +8
============================================
Files 84 84
Lines 7197 7223 +26
Branches 1430 1437 +7
============================================
+ Hits 6342 6366 +24
Misses 430 430
- Partials 425 427 +2 ☔ View full report in Codecov by Sentry. |
yuxincs
approved these changes
Dec 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our previous code would crash on nested generic types or when multiple unbounded wildcard type arguments were passed consecutively.