Patching not working since Errorprone 2.26.0 #1080
Description
Since Errorprone 2.26.0, and perhaps this change google/error-prone#4028, patching does not seem to work with NullAway. Instead we get the following error:
An exception has occurred in the compiler (21.0.5). Please file a bug against the Java compiler via the Java bug reporting page (https://bugreport.java.com) after checking the Bug Database (https://bugs.java.com) for duplicates. Include your program, the following diagnostic, and the parameters passed to the Java compiler in your report. Thank you.
com.google.errorprone.scanner.ErrorProneInjector$ProvisionException: Failed to initialize com.uber.nullaway.NullAway
at com.google.errorprone.scanner.ErrorProneInjector.getInstance(ErrorProneInjector.java:92)
at com.google.errorprone.scanner.ErrorProneInjector.getInstance(ErrorProneInjector.java:65)
at com.google.errorprone.scanner.ScannerSupplierImpl.instantiateChecker(ScannerSupplierImpl.java:66)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1939)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
at com.google.errorprone.scanner.ScannerSupplierImpl.get(ScannerSupplierImpl.java:74)
at com.google.errorprone.scanner.ScannerSupplierImpl.get(ScannerSupplierImpl.java:37)
at com.google.errorprone.ErrorProneAnalyzer.lambda$createAnalyzer$1(ErrorProneAnalyzer.java:91)
at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:200)
at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:227)
at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:133)
at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1436)
at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1383)
at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:963)
at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:319)
at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:178)
at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)
Caused by: java.lang.reflect.InvocationTargetException
at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:74)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
at com.google.errorprone.scanner.ErrorProneInjector.getInstance(ErrorProneInjector.java:90)
... 23 more
Caused by: java.lang.IllegalStateException: DO NOT report an issue to Error Prone for this crash! NullAway configuration is incorrect. Must specify annotated packages, using the -XepOpt:NullAway:AnnotatedPackages=[...] flag. If you feel you have gotten this message in error report an issue at https://github.com/uber/NullAway/issues.
at com.uber.nullaway.ErrorProneCLIFlagsConfig.<init>(ErrorProneCLIFlagsConfig.java:241)
at com.uber.nullaway.NullAway.<init>(NullAway.java:293)
at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
... 26 more
This is using NullAway 0.12.1 and javac with -Xep:NullAway:WARN -XepOpt:NullAway:AnnotatedPackages=com.helloworld -XepOpt:NullAway:SuggestSuppressions=true -XepPatchChecks:NullAway -XepPatchLocation:/tmp/tmp.patch. I've tried various combinations of these settings, e.g. including and excluding -Xep:NullAway:WARN with the same results.
This works as expected with Errorprone 2.25.0, and does not work with Errorprone from 2.26.0 up until at least 2.35.1.
Not sure if this is best reported here or with Errorprone, but following the advise in the error message :)