Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: uber/NullAway
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.12.7
Choose a base ref
...
head repository: uber/NullAway
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.12.8
Choose a head ref
  • 17 commits
  • 48 files changed
  • 5 contributors

Commits on Apr 30, 2025

  1. Configuration menu
    Copy the full SHA
    8873322 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb847a4 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2025

  1. Configuration menu
    Copy the full SHA
    ffbf342 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2025

  1. Configuration menu
    Copy the full SHA
    b9815a6 View commit details
    Browse the repository at this point in the history
  2. Allowing NewClassTree to be passed into getGenericParameterNullnessAt…

    …Invocation (#1210)
    
    ### unit test: newNullableWithArg()
    
    Generalised the parameters of getGenericParameterNullnessAtInvocation to
    accept NewClassTree
    
    Fixes #1214
    
    ---------
    
    Co-authored-by: Manu Sridharan <[email protected]>
    dhruv-agr and msridhar authored May 10, 2025
    Configuration menu
    Copy the full SHA
    56c7f2b View commit details
    Browse the repository at this point in the history

Commits on May 23, 2025

  1. Configuration menu
    Copy the full SHA
    ec6d829 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2025

  1. Handle NewClassTree in compareGenericTypeParameterNullabilityForCall(#…

    …1212) (#1217)
    
    Handle NewClassTree for constructor type substitution in
    compareGenericTypeParameterNullabilityForCall.
    
    Addresses part of #1212
    
    ---------
    
    Co-authored-by: Manu Sridharan <[email protected]>
    dhruv-agr and msridhar authored Jun 4, 2025
    Configuration menu
    Copy the full SHA
    6cfccfd View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2025

  1. More flexible handling of AssertJ isNotNull methods (#1221)

    Fixes #1219 
    
    Previously, we would only consider the `isNotNull` method of
    `org.assertj.core.api.AbstractAssert` to be valid. Now, we allow
    `isNotNull` of any class that implements the
    `org.assertj.core.api.Assert` interface, which handles the case from
    #1219 and more.
    msridhar authored Jun 18, 2025
    Configuration menu
    Copy the full SHA
    5209429 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2025

  1. Fix broken link to Eradicate in README.md (#1227)

    This PR fixes the broken link to the Eradicate that has been removed in
    the latest version in the `README.md`.
    
    See https://github.com/facebook/infer/blob/main/Changelog.md#checkers
    izeye authored Jun 28, 2025
    Configuration menu
    Copy the full SHA
    5b22fb4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e39856e View commit details
    Browse the repository at this point in the history
  3. Support AssertJ hasSize() (#1229)

    This PR changes to support AssertJ `hasSize()`.
    
    See gh-1224
    izeye authored Jun 28, 2025
    Configuration menu
    Copy the full SHA
    a6273b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2025

  1. Configuration menu
    Copy the full SHA
    20dd152 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2025

  1. Prototype implementation of javac plugin to serialize nullness annota…

    …tions (#1225)
    
    This is a new approach to serializing the annotations from
    https://github.com/jspecify/jdk for use with NullAway. The idea is we
    build that JDK with this plugin, which will dump out all the discovered
    annotation info into JSON files. Then, we write some code to take all
    those JSON files and convert them to astubx for NullAway. I went with
    JSON instead of directly serializing astubx to iterate more quickly. I
    have tested with jspecify/jdk and confirmed I can inject this plugin
    into the build and the output JSON files get created. I haven't started
    on the code to convert the JSON to astubx yet.
    
    Of course there is much left to do, but I wanted to get this initial
    implementation up for review rather than dropping a huge PR at the end
    (and also to enable others to help out). We previously thought about
    getting out the JDK annotations by parsing the source files (and wrote
    some code to do so), but I think this approach will be more robust, as
    in the javac plugin we don't need worry about parsing of recent language
    features and all symbols are just resolved.
    
    Related to #950 (which probably needs to be updated if we go forward
    with this approach)
    msridhar authored Jul 8, 2025
    Configuration menu
    Copy the full SHA
    10d4fee View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2025

  1. Add AdditionalSuppressionNames configuration option (#1231)

    Prior to this change, NullAway could be skipped only with an explicit
    `@SuppressWarnings("NullAway")` annotation. However, existing
    inspections like `DataFlowIssue` by JetBrains imply that NullAway should
    be skipped too.
    
    With this change, NullAway can be configured to back off when additional
    names are present, via the `SuppressionNameAliases` configuration
    option.
    
    * Closes #1230
    scordio authored Jul 23, 2025
    Configuration menu
    Copy the full SHA
    de6b680 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2025

  1. Updates to deploy releases to Central Portal (#1234)

    Fixes #1218. I also updated the Shadow plugin to a more recent version,
    as that often has subtle interactions with releasing.
    
    To test, I followed the instructions at
    https://github.com/vanniktech/gradle-maven-publish-plugin/releases/tag/0.33.0.
    I successfully uploaded a `SNAPSHOT` release with these changes, but we
    should cut a normal release after this lands to make sure that works.
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    * **Chores**
    * Updated Maven Publish Gradle plugin and Shadow plugin to newer
    versions.
      * Switched Shadow plugin provider to improve build configuration.
      * Updated publishing properties to enable Maven Central publishing.
      * Adjusted build tasks to use updated Javadoc JAR task names.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    msridhar authored Aug 4, 2025
    Configuration menu
    Copy the full SHA
    d655f8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee85996 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2025

  1. Prepare for release 0.12.8.

    yuxincs committed Aug 6, 2025
    Configuration menu
    Copy the full SHA
    eed74de View commit details
    Browse the repository at this point in the history
Loading