Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: uber/NullAway
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.12.4
Choose a base ref
...
head repository: uber/NullAway
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.12.5
Choose a head ref
  • 12 commits
  • 33 files changed
  • 4 contributors

Commits on Feb 27, 2025

  1. Configuration menu
    Copy the full SHA
    f97d585 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0888040 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2025

  1. Add missing override to RestoreNullnessAnnotationsVisitor (#1154)

    We missed the case for `ForAll` types (for generic methods)
    
    Fixes #1129
    msridhar authored Mar 4, 2025
    Configuration menu
    Copy the full SHA
    baf8f77 View commit details
    Browse the repository at this point in the history
  2. Add more bailouts for raw types (#1153)

    Fixes #1151 
    
    The extra check in `CheckIdenticalNullabilityVisitor` is not needed to
    fix this bug but seemed like a prudent addition.
    msridhar authored Mar 4, 2025
    Configuration menu
    Copy the full SHA
    635ecd2 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2025

  1. Configuration menu
    Copy the full SHA
    7a89102 View commit details
    Browse the repository at this point in the history
  2. JSpecify: infer generic method type arguments for assignments (#1131)

    This PR infers nullability of generic method type arguments for the case
    where the result of the call is assigned to a variable, e.g.:
    ```java
      class Foo<T extends @nullable Object> {
        Foo(T t) {}
        static <U extends @nullable Object> Foo<U> make(U u) { return new Foo<>(u); }
        void test() {
          Foo<@nullable Object> f1 = Foo.make(null); // legal
          Foo<Object> f2 = Foo.make(null); // error reported; arg cannot be @nullable
        }
      }
    ```
    See the tests for (many) more examples.
    
    ---------
    
    Co-authored-by: Manu Sridharan <[email protected]>
    haewiful and msridhar authored Mar 13, 2025
    Configuration menu
    Copy the full SHA
    8786e88 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2025

  1. JSpecify: properly handle lambdas in anonymous inner classes (#1165)

    Fixes #1156
    
    When checking correctness of lambda overrides we get the type from
    `javac`'s inferred type rather than using the enclosing class. Also,
    when getting the type of an anonymous class we add some extra assertions
    to ensure we find the right `NewClassTree` representing the anonymous
    class. I _think_ we'll always get the right tree now, but the asserts
    give peace of mind.
    msridhar authored Mar 17, 2025
    Configuration menu
    Copy the full SHA
    0161a80 View commit details
    Browse the repository at this point in the history
  2. Support @MonotonicNonNull on static fields (#1166)

    Fixes #1160 
    
    Add more tests for other cases also
    msridhar authored Mar 17, 2025
    Configuration menu
    Copy the full SHA
    0825436 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2025

  1. Update to Error Prone 2.37.0 (#1169)

    We suppress some warnings on tests as they will be much easier to fix
    with text blocks, which we can only use once we require JDK 17 (see
    #1170).
    msridhar authored Mar 24, 2025
    Configuration menu
    Copy the full SHA
    685065a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3da2c82 View commit details
    Browse the repository at this point in the history
  3. Don't treat @ParametricNullness as @Nullable in JSpecify mode (#1174

    )
    
    Fixes #1173 
    
    In JSpecify mode, we should rely on our checking of generic types and
    not treat `@ParametricNullness` as a `@Nullable` annotation.
    msridhar authored Mar 24, 2025
    Configuration menu
    Copy the full SHA
    b84feb7 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2025

  1. Prepare for release 0.12.5.

    yuxincs committed Mar 26, 2025
    Configuration menu
    Copy the full SHA
    9613fb7 View commit details
    Browse the repository at this point in the history
Loading