-
Notifications
You must be signed in to change notification settings - Fork 336
Comparing changes
Open a pull request
base repository: uber/NullAway
base: v0.12.2
head repository: uber/NullAway
compare: v0.12.3
- 17 commits
- 39 files changed
- 3 contributors
Commits on Dec 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9ff664a - Browse repository at this point
Copy the full SHA 9ff664aView commit details
Commits on Dec 16, 2024
-
Remove
InferredJARModelsHandler(#1079)Now, all logic for parsing loading `astubx` files is consolidated into the `LibraryModelsHandler.ExternalStubxLibraryModels` class and is uniform for `astubx` files generated via JarInfer or from source code, which will ease future bug fixes and changes. We copied over the logic from `InferredJARModelsHandler` for loading Android SDK models if present. We also update the logic for `ExternalStubxLibraryModels.nonNullParameters()` and `ExternalStubxLibraryModels.nullableReturns()` to pull in all the relevant info from the parsed `astubx` file. Fixes #1072
Configuration menu - View commit details
-
Copy full SHA for cb3ff51 - Browse repository at this point
Copy the full SHA cb3ff51View commit details
Commits on Dec 17, 2024
-
Fix crash with annotation on enum (#1097)
Fixes #1093 We just missed a case.
Configuration menu - View commit details
-
Copy full SHA for 346b9b0 - Browse repository at this point
Copy the full SHA 346b9b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18c9723 - Browse repository at this point
Copy the full SHA 18c9723View commit details
Commits on Dec 18, 2024
-
Handle case null in switch statements (#1100)
In Java 21+, when a `switch` statement contains `case null`, the expression being switched on is allowed to be `null`. Fixes #930
Configuration menu - View commit details
-
Copy full SHA for 41c7c55 - Browse repository at this point
Copy the full SHA 41c7c55View commit details
Commits on Dec 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b7dad0c - Browse repository at this point
Copy the full SHA b7dad0cView commit details
Commits on Dec 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f17b330 - Browse repository at this point
Copy the full SHA f17b330View commit details
Commits on Dec 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d0502e8 - Browse repository at this point
Copy the full SHA d0502e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2754c45 - Browse repository at this point
Copy the full SHA 2754c45View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2bafb2 - Browse repository at this point
Copy the full SHA f2bafb2View commit details
Commits on Dec 23, 2024
-
Build latest Caffeine on CI (#1111)
Fixes #1110 We can see how this goes for some time before making it a required job.
Configuration menu - View commit details
-
Copy full SHA for 728bf77 - Browse repository at this point
Copy the full SHA 728bf77View commit details
Commits on Dec 24, 2024
-
Properly handle nested generics and multiple wildcard type args in Ja…
…rInfer (#1114) Our previous code would crash on nested generic types or when multiple unbounded wildcard type arguments were passed consecutively.
Configuration menu - View commit details
-
Copy full SHA for 17df87f - Browse repository at this point
Copy the full SHA 17df87fView commit details
Commits on Dec 26, 2024
-
[refactoring] Wrap calls to Types.subst and Types.memberType (#1115)
This is in preparation to attempt to fix #1091. Just a refactoring, no behavior changes.
Configuration menu - View commit details
-
Copy full SHA for 7cb6b98 - Browse repository at this point
Copy the full SHA 7cb6b98View commit details -
Proper checking of vararg overrides with JSpecify annotations (#1116)
Fixes #1113 We weren't calling the right API to check the nullability of a varargs argument when checking valid overriding. Most of this PR is tests to check handling of most of the cases.
Configuration menu - View commit details
-
Copy full SHA for 6d331c7 - Browse repository at this point
Copy the full SHA 6d331c7View commit details -
Add flag to indicate only @NullMarked code should be checked (#1117)
Fixes #574 We add a new flag `OnlyNullMarked` to indicate that NullAway can only check code that is `@NullMarked`, and hence it is ok to omit the (previously required) `AnnotatedPackages` flag. We currently require _exactly_ one of either `AnnotatedPackages` or `OnlyNullMarked` to be passed in; if both flags are omitted or both flags are passed, we fail. As JSpecify and `@NullMarked` become more widely adopted, we may change the policy to allow neither flag to be passed (as NullAway already checks `@NullMarked` code out of the box). But for now, we require one of the flags to be passed, to avoid confusion.
Configuration menu - View commit details
-
Copy full SHA for 43054bb - Browse repository at this point
Copy the full SHA 43054bbView commit details
Commits on Dec 28, 2024
-
Add support for static fields in contracts (#1118)
This PR adds support for static fields in `@EnsureNonnull`,`EnsureNonnullIf`,`@RequiresNonnull` annotations. Currently the following code will throw validation errors (as well as the annotation handlers are unable to handle static fields). However, after this change, static fields for all three annotations are supported ``` class Foo { @nullable static Item staticNullableItem; @EnsuresNonNull("staticNullableItem") public static void initializeStaticField() { staticNullableItem = new Item(); } @RequiresNonNull("staticNullableItem") public static void useStaticField() { staticNullableItem.call(); } @EnsuresNonNullIf(value="staticNullableItem", result=true) public static boolean hasStaticNullableItem() { return staticNullableItem != null; } } ``` Fixes #431 --------- Co-authored-by: Manu Sridharan <[email protected]>Configuration menu - View commit details
-
Copy full SHA for aaf9f08 - Browse repository at this point
Copy the full SHA aaf9f08View commit details
Commits on Jan 6, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 39b376c - Browse repository at this point
Copy the full SHA 39b376cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.12.2...v0.12.3