Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: uber/NullAway
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.12.13
Choose a base ref
...
head repository: uber/NullAway
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.12.14
Choose a head ref
  • 9 commits
  • 16 files changed
  • 3 contributors

Commits on Dec 1, 2025

  1. Configuration menu
    Copy the full SHA
    f39e5bd View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2025

  1. Fix arg concatenation bug in JMH (#1357)

    Before we were missing a space character so the Error Prone args were
    not getting passed properly. Do some related minor cleanup.
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    * **Refactor**
    * Internal assembly of compiler/analyzer invocation arguments was
    reorganized for clearer, centralized construction; no behavior change.
    * **New Feature**
    * Added a new type-annotation handling option to improve
    JSpecify/type-annotation processing during analysis.
    * **Other**
      * No changes to public API or user workflows.
    
    <sub>✏️ Tip: You can customize this high-level summary in your review
    settings.</sub>
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    msridhar authored Dec 2, 2025
    Configuration menu
    Copy the full SHA
    2294177 View commit details
    Browse the repository at this point in the history
  2. Various optimizations (#1358)

    These were showing up in profiles. Note that one of the fixes requires
    updating our minimum supported Guava version to 31.1. This was
    [released](https://github.com/google/guava/releases/tag/v31.1) in
    February 2022, and mostly Guava is backward compatible these days, so
    hopefully it's fine for users.
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    * **Refactor**
      * Added cached hash/identity values to reduce repeated recomputation.
    * Optimized nullness-store merging with faster merge and identity
    short-circuit.
      * Builder internals switched to immutable-building semantics.
      * Improved error-message construction formatting.
    
    * **Chores**
      * Bumped Guava dependency to a newer version.
      * Added Guava to the oldest-error-prone test classpath.
    
    <sub>✏️ Tip: You can customize this high-level summary in your review
    settings.</sub>
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    
    ---------
    
    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    msridhar and coderabbitai[bot] authored Dec 2, 2025
    Configuration menu
    Copy the full SHA
    effe83d View commit details
    Browse the repository at this point in the history
  3. move wildcard-related tests to a separate test class (#1361)

    The `GenericMethodTests` class is getting huge so this helps a little.
    Also, add a new simple wildcard test to aid when we start working on
    #1360.
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    * **Tests**
    * Reorganized wildcard and generic type inference test cases into a
    dedicated test class for improved organization and maintainability.
    
    <sub>✏️ Tip: You can customize this high-level summary in your review
    settings.</sub>
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    msridhar authored Dec 2, 2025
    Configuration menu
    Copy the full SHA
    9a882ee View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2025

  1. Don't report matches from RequireExplicitNullMarking when run at SUGG…

    …ESTION level (#1365)
    
    Fixes #1363. What we really want to do is ship this check in a disabled
    state, but I don't immediately see a way to do that. So, as a
    workaround, don't emit matches when the check is run at the `SUGGESTION`
    level.
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    * **Bug Fixes**
    * The RequireExplicitNullMarking checker now respects severity level
    configuration and no longer produces diagnostic reports at the default
    SUGGESTION level, reducing unnecessary noise in build outputs.
    
    <sub>✏️ Tip: You can customize this high-level summary in your review
    settings.</sub>
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    msridhar authored Dec 4, 2025
    Configuration menu
    Copy the full SHA
    e4999a6 View commit details
    Browse the repository at this point in the history
  2. Optimize methods that check for annotations on a Symbol (#1362)

    These methods are called very frequently. Previously these methods
    operated on `Stream`s, but that was causing overhead visible in
    profiles. Switch them to use `Iterator`s and a callback `Predicate`.
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    * **Refactor**
    * Consolidated annotation-checking logic by introducing a centralized
    utility method to streamline multiple annotation-matching operations
    into a single, reusable component.
    * Replaced stream-based checks with explicit iteration for improved
    performance and code consistency across annotation-checking operations.
    
    <sub>✏️ Tip: You can customize this high-level summary in your review
    settings.</sub>
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    msridhar authored Dec 4, 2025
    Configuration menu
    Copy the full SHA
    291abc5 View commit details
    Browse the repository at this point in the history
  3. Tune warning message for RequireExplicitNullMarking (#1366)

    Fixes #1364 
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    * **Documentation**
    * Enhanced diagnostic messages with improved formatting and clearer
    scope identification.
    
    <sub>✏️ Tip: You can customize this high-level summary in your review
    settings.</sub>
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    msridhar authored Dec 4, 2025
    Configuration menu
    Copy the full SHA
    1d43cb1 View commit details
    Browse the repository at this point in the history
  4. Changelog for version 0.12.14 (#1367)

    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    * **Documentation**
    * Added a Version 0.12.14 entry to the changelog and preserved prior
    entries.
    
    * **Bug Fixes**
    * RequireExplicitNullMarking is now disabled by default, fixing related
    configuration issues.
    
    * **Chores**
    * Applied performance optimizations and general maintenance
    improvements.
    
    <sub>✏️ Tip: You can customize this high-level summary in your review
    settings.</sub>
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    
    ---------
    
    Co-authored-by: Yuxin Wang <[email protected]>
    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    3 people authored Dec 4, 2025
    Configuration menu
    Copy the full SHA
    4fb78e0 View commit details
    Browse the repository at this point in the history
  5. Prepare for release 0.12.14.

    yuxincs committed Dec 4, 2025
    Configuration menu
    Copy the full SHA
    73b0376 View commit details
    Browse the repository at this point in the history
Loading