Support java.util.Objects.toString() (#1283)

gulikoza · web-flow · commit cb72c5a6c477 · 2025-09-10T14:12:58.000-07:00
Add support for java.util.Objects.toString(). Closes #1282 When passing `null` as a nullDefault String, the Object is not guaranteed nonNull.  ## Summary by CodeRabbit * **Bug Fixes** * Improved nullability analysis for java.util.Objects.toString(Object, String). The return value is now considered nullable when the default string argument may be null, preventing unsafe dereferences. Calls with a non-null default string remain treated as non-null. * **Tests** * Added a test validating the updated behavior for Objects.toString with both non-null and null default string arguments.  Co-authored-by: gulikoza <gulikoza@users.noreply.github.com>
diff --git a/nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java b/nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java
@@ -812,6 +812,7 @@ private static class DefaultLibraryModels implements LibraryModels {
                 methodRef(
                     "com.google.common.collect.ImmutableMap", "getOrDefault(java.lang.Object,V)"),
                 1)
+            .put(methodRef("java.util.Objects", "toString(java.lang.Object,java.lang.String)"), 1)
             .build();
 
     private static final ImmutableSet<MethodRef> NULLABLE_RETURNS =
diff --git a/nullaway/src/test/java/com/uber/nullaway/FrameworkTests.java b/nullaway/src/test/java/com/uber/nullaway/FrameworkTests.java
@@ -1154,6 +1154,26 @@ public void amazonAwsStringUtilsIsEmptyOrIsBlank() {
         .doTest();
   }
 
+  @Test
+  public void defaultLibraryModelsObjectToString() {
+    defaultCompilationHelper
+        .addSourceLines(
+            "Test.java",
+            "package com.uber;",
+            "import java.util.Objects;",
+            "import javax.annotation.Nullable;",
+            "public class Test {",
+            "  void objectsToString(@Nullable Object o) {",
+            "    String p = Objects.toString(o, \"foo\");",
+            "    String n = Objects.toString(o, null);",
+            "    p.hashCode();",
+            "    // BUG: Diagnostic contains: dereferenced",
+            "    n.hashCode();",
+            "  }",
+            "}")
+        .doTest();
+  }
+
   @Test
   public void filesIsDirectory() {
     defaultCompilationHelper
